Subject: Re: [PATCH 3/3] color: add support for 12-bit RGB colors

From: Junio C Hamano <[email-masked]>
Date: Tue, 30 Apr 2024 12:01:54 -0700

Junio C Hamano <[email-masked]> writes:

> Ah, I take it back.  The preimage was added by [2/3] so it is fair
> to say that that step would be the right place to do that from the
> get-go.

Perhaps something like this can be squashed in.

Subject: [PATCH] fixup! t/t4026-color: add test coverage for invalid RGB colors

---
 t/t4026-color.sh | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/t/t4026-color.sh b/t/t4026-color.sh
index 9a6f8a4bc5..e60aa588c2 100755
--- a/t/t4026-color.sh
+++ b/t/t4026-color.sh
@@ -140,6 +140,14 @@ test_expect_success 'extra character after attribute' '
 	invalid_color "dimX"
 '
 
+test_expect_success 'wrong number of letters in RGB color' '
+	invalid_color "#1" &&
+	invalid_color "#23" &&
+	invalid_color "#4567" &&
+	invalid_color "#89abc" &&
+	invalid_color "#def0123"
+'
+
 test_expect_success 'non-hex character in RGB color' '
 	invalid_color "#x23456" &&
 	invalid_color "#1x3456" &&
-- 
2.45.0