Subject: Re: [BUG] range expressions in GIT_SKIP_TESTS are broken in master (was [BUG] question mark in GIT_SKIP_TESTS is broken in master)

From: Junio C Hamano <[email-masked]>
Date: Wed, 16 Jun 2021 12:28:21 +0900

Andrei Rybak <[email-masked]> writes:

> I sent this originally with incorrect subject. Question marks, e.g.
>
>     $ GIT_SKIP_TESTS='t000?' make
>
> work.  It is the range expressions, like [0-9] that are broken:
>
>     $ GIT_SKIP_TESTS='t[0-9]000' make

This reproduces for me, and

      $ GIT_SKIP_TESTS=t?000' sh t0000-basic.sh
      $ GIT_SKIP_TESTS=t0?00' sh t0000-basic.sh
      $ GIT_SKIP_TESTS=t00?0' sh t0000-basic.sh

tells me that "Question marks work" above is not exactly correct.
It is an exception that this

      $ GIT_SKIP_TESTS=t000?' sh t0000-basic.sh

happens to skip.

Interestingly enough, edc23840b0 (test-lib: bring $remove_trash out
of retirement, 2021-05-10) cleanly reverts without being depended on
by anything else in the series.

Ævar?

Thanks.