Subject: Re: [PATCH v2] Documentation/git-config.txt: reword missleading sentence

From: Junio C Hamano <[email-masked]>
Date: Fri, 13 Oct 2017 09:23:20 +0900

[email-masked] writes:

> From: PAYRE NATHAN p1508475 <[email-masked]>

Should I assume that the name/address on the last Signed-off-by: we
see below is what you want to be known as?  As a part of school
work, I'd imagine that Matthieu wants your work to be associated
with the univ-lyon1.fr address, so perhaps you want to go the other
way around?  It's not my place to decide between the two, but it is
unusual to see that the name/address of the author (which is the
above line) does not match what is on the Signed-off-by: line.

> Change the word "bla" to "section.variable", "bla" is a placeholder
> for a variable name and it wasn't clear for everyone.
> This change clarify it.
>
> Change the appearance of 'git config section.variable {tilde}/' to
> `git config section.variable {tilde}/` to harmonize it with
> the rest of the file, this is a command line then the "`" are
> necessary.
>
> Replace "git-config" by "git config" because the command
> is not "git-config".
>
> See discussion at:
> https://public-inbox.org/git/[email-masked]/
>
> Signed-off-by: MOY Matthieu <[email-masked]>
> Signed-off-by: Daniel Bensoussan <[email-masked]>
> Signed-off-by: Timothee Albertin <[email-masked]>
> Signed-off-by: Nathan Payre <[email-masked]>
> Noticed-by: [email-masked]
> ---
>  Documentation/git-config.txt | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/git-config.txt b/Documentation/git-config.txt
> index 83f86b923..2ab9e4c56 100644
> --- a/Documentation/git-config.txt
> +++ b/Documentation/git-config.txt
> @@ -174,11 +174,11 @@ See also <<FILES>>.
>  	either --bool or --int, as described above.
>  
>  --path::
> -	'git-config' will expand leading '{tilde}' to the value of
> +	'git config' will expand leading '{tilde}' to the value of
>  	'$HOME', and '{tilde}user' to the home directory for the
>  	specified user.  This option has no effect when setting the
> -	value (but you can use 'git config bla {tilde}/' from the
> -	command line to let your shell do the expansion).
> +	value (but you can use `git config section.variable {tilde}/`

Does this reference to {tilde} get expanded inside the `literal`
mark-up?  In the description for 'gitdir', we find this passage (in
Documentation/config.txt):

     * If the pattern starts with `~/`, `~` will be substituted with the
       content of the environment variable `HOME`.

So I'd expect `~` to be a safe way to get what you want, not `{tilde}`.

> +	from the command line to let your shell do the expansion).
>  
>  -z::
>  --null::