Subject: Re: [PATCH v5 09/11] Test read_early_config()

From: Junio C Hamano <[email-masked]>
Date: Fri, 10 Mar 2017 11:02:19 -0800

Johannes Schindelin <[email-masked]> writes:

> Subject: Re: [PATCH v5 09/11] Test read_early_config()

Let's retitle it to

	t1309: test read_early_config()

> So far, we had no explicit tests of that function.
>
> Signed-off-by: Johannes Schindelin <[email-masked]>
> ---
>  t/helper/test-config.c  | 15 +++++++++++++++
>  t/t1309-early-config.sh | 50 +++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 65 insertions(+)
>  create mode 100755 t/t1309-early-config.sh
>
> diff --git a/t/helper/test-config.c b/t/helper/test-config.c
> index 83a4f2ab869..8e3ed6a76cb 100644
> --- a/t/helper/test-config.c
> +++ b/t/helper/test-config.c
> @@ -66,6 +66,16 @@ static int iterate_cb(const char *var, const char *value, void *data)
>  	return 0;
>  }
>  
> +static int early_config_cb(const char *var, const char *value, void *vdata)
> +{
> +	const char *key = vdata;
> +
> +	if (!strcmp(key, var))
> +		printf("%s\n", value);
> +
> +	return 0;
> +}
> +
>  int cmd_main(int argc, const char **argv)
>  {
>  	int i, val;
> @@ -73,6 +83,11 @@ int cmd_main(int argc, const char **argv)
>  	const struct string_list *strptr;
>  	struct config_set cs;
>  
> +	if (argc == 3 && !strcmp(argv[1], "read_early_config")) {
> +		read_early_config(early_config_cb, (void *)argv[2]);
> +		return 0;
> +	}
> +
>  	setup_git_directory();

Makes perfect sense to have this as the very beginning, before we
even do the usual setup ;-)