From: Junio C Hamano <gitster@pobox•com>
To: git@vger•kernel.org
Cc: "René Scharfe" <l.s.r@web•de>,
"Johannes Schindelin" <Johannes.Schindelin@gmx•de>,
"Pranit Bauva" <pranit.bauva@gmail•com>
Subject: Re: [PATCH] fixup! bisect--helper: `bisect_next_check` & bisect_voc shell function in C
Date: Sat, 18 Feb 2017 18:06:58 -0800 [thread overview]
Message-ID: <xmqqa89jlyrh.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <xmqqinodewdr.fsf@gitster.mtv.corp.google.com> (Junio C. Hamano's message of "Mon, 13 Feb 2017 11:14:24 -0800")
Junio C Hamano <gitster@pobox•com> writes:
> ...
> So, let's give Pranit a concrete "here is what we want to see
> squashed in", while you guys discuss peculiarity with various
> platforms and their system headers, which admittedly is a more
> interesting tangent ;-)
>
> There are early returns with "goto finish" even before _syn
> variables are first assigned to, so they would need to be
> initialized to NULL. The other two get their initial values
> right at the beginning, so they are OK.
>
> builtin/bisect--helper.c | 14 +++++---------
> 1 file changed, 5 insertions(+), 9 deletions(-)
While we are waiting for the topic to be fixed, I've tentatively
applied this on top to update 'pu', so Travis should now be happy
with 'pu' on Mac, too.
prev parent reply other threads:[~2017-02-19 2:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-10 14:20 [PATCH] fixup! bisect--helper: `bisect_next_check` & bisect_voc shell function in C Johannes Schindelin
2017-02-10 15:30 ` Pranit Bauva
2017-02-10 20:47 ` René Scharfe
2017-02-13 16:23 ` Johannes Schindelin
2017-02-13 18:27 ` René Scharfe
2017-02-13 19:14 ` Junio C Hamano
2017-02-13 19:34 ` Pranit Bauva
2017-02-19 2:06 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqa89jlyrh.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=Johannes.Schindelin@gmx$(echo .)de \
--cc=git@vger$(echo .)kernel.org \
--cc=l.s.r@web$(echo .)de \
--cc=pranit.bauva@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox