From: Junio C Hamano <gitster@pobox•com>
To: Philip Oakley <philipoakley@iee•org>
Cc: GitList <git@vger•kernel.org>
Subject: Re: [PATCH] doc: fix merge-base ASCII art tab spacing
Date: Thu, 20 Oct 2016 17:27:44 -0700 [thread overview]
Message-ID: <xmqqa8dyeebj.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20161020234009.1768-1-philipoakley@iee.org> (Philip Oakley's message of "Fri, 21 Oct 2016 00:40:09 +0100")
Philip Oakley <philipoakley@iee•org> writes:
> The doc-tool stack does not always respect the 'tab = 8 spaces' rule,
> particularly the git-scm doc pages https://git-scm.com/docs/git-merge-base
> and the Git generated html pages.
Sorry, but I do not understand this change.
https://git.github.io/htmldocs/git-merge-base.html is "Git generated
HTML page" and I do not see any breakage around the drawings this
patch touches, and the fp-path series does not touch these drawings,
either.
If a broken "doc-tool stack" breaks the formatting, I'd prefer to
see that "doc-tool stack" fixed, instead of working around by
updating the source they work on. Otherwise, the broken "doc-tool
stack" will keep producing broken output next time a source that
respects "tab is to skip to the next multiple of 8" rule is fed to
it, no?
next prev parent reply other threads:[~2016-10-21 0:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-20 23:40 [PATCH] doc: fix merge-base ASCII art tab spacing Philip Oakley
2016-10-21 0:22 ` Jeff King
2016-10-21 0:48 ` Junio C Hamano
2016-10-21 0:27 ` Junio C Hamano [this message]
2016-10-21 21:26 ` Philip Oakley
2016-10-21 22:54 ` Junio C Hamano
2016-10-22 5:45 ` Philip Oakley
2016-10-24 21:54 ` [PATCH] doc: fix the 'revert a faulty merge' " Philip Oakley
2016-10-25 11:39 ` Johannes Schindelin
2016-10-22 1:09 ` [PATCH] doc: fix merge-base " Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqa8dyeebj.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=philipoakley@iee$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox