From: Junio C Hamano <gitster@pobox•com>
To: Matthieu Moy <Matthieu.Moy@imag•fr>
Cc: git@vger•kernel.org
Subject: Re: [PATCH 0/5] activate diff.renames by default
Date: Tue, 23 Feb 2016 11:17:12 -0800 [thread overview]
Message-ID: <xmqqa8mr1bk7.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <1456249498-3232-1-git-send-email-Matthieu.Moy@imag.fr> (Matthieu Moy's message of "Tue, 23 Feb 2016 18:44:53 +0100")
Matthieu Moy <Matthieu.Moy@imag•fr> writes:
> I have always wondered why diff.renames was not activated by default.
> I've had it to true in my configuration for 9 years, and I've been
> teaching newbies to set it for a while without issue. I think it's
> time to activate it by default, but please let me know if I missed a
> reason to keep it to false.
>
> In any case, the first 3 patches are useful cleanups.
It's a long time coming since I heard "I love how I can just say
'oh, keep in mind that we might want to..' and 24 hours later you
did it." [*1*]
I can hardly be an impartial judge for this series, though.
[Reference]
*1* http://thread.gmane.org/gmane.comp.version-control.git/3541/focus=3702
> Matthieu Moy (5):
> Documentation/diff-config: fix description of diff.renames
> t4001-diff-rename: wrap file creations in a test
> t: add tests for diff.renames (true/false/unset)
> log: introduce init_log_defaults()
> diff: activate diff.renames by default
>
> Documentation/diff-config.txt | 7 ++--
> builtin/commit.c | 1 +
> builtin/diff.c | 1 +
> builtin/log.c | 16 ++++---
> builtin/merge.c | 1 +
> diff.c | 5 +++
> diff.h | 1 +
> t/t4001-diff-rename.sh | 97 +++++++++++++++++++++++++++++++++++--------
> t/t4013-diff-various.sh | 2 +
> t/t4014-format-patch.sh | 4 +-
> t/t4047-diff-dirstat.sh | 3 +-
> t/t4202-log.sh | 8 ++--
> 12 files changed, 114 insertions(+), 32 deletions(-)
next prev parent reply other threads:[~2016-02-23 19:17 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-23 17:44 [PATCH 0/5] activate diff.renames by default Matthieu Moy
2016-02-23 17:44 ` [PATCH 1/5] Documentation/diff-config: fix description of diff.renames Matthieu Moy
2016-02-24 10:27 ` Jeff King
2016-02-25 17:27 ` Felipe Gonçalves Assis
2016-02-25 17:34 ` Matthieu Moy
2016-02-23 17:44 ` [PATCH 2/5] t4001-diff-rename: wrap file creations in a test Matthieu Moy
2016-02-24 10:25 ` Jeff King
2016-02-24 13:16 ` Matthieu Moy
2016-02-23 17:44 ` [PATCH 3/5] t: add tests for diff.renames (true/false/unset) Matthieu Moy
2016-02-23 17:44 ` [PATCH 4/5] log: introduce init_log_defaults() Matthieu Moy
2016-02-23 17:44 ` [PATCH 5/5] diff: activate diff.renames by default Matthieu Moy
2016-02-23 21:01 ` Junio C Hamano
2016-02-23 21:11 ` Matthieu Moy
2016-02-24 10:42 ` Jeff King
2016-02-25 8:54 ` Matthieu Moy
2016-02-23 19:17 ` Junio C Hamano [this message]
2016-02-23 20:46 ` [PATCH 0/5] " Matthieu Moy
2016-02-23 21:40 ` Junio C Hamano
2016-02-25 8:59 ` [PATCH v2 " Matthieu Moy
2016-02-25 8:59 ` [PATCH v2 1/5] Documentation/diff-config: fix description of diff.renames Matthieu Moy
2016-02-25 17:37 ` [PATCH v2.1] " Matthieu Moy
2016-02-25 18:18 ` Junio C Hamano
2016-02-25 17:53 ` [PATCH v2 1/5] " Junio C Hamano
2016-02-25 8:59 ` [PATCH v2 2/5] t4001-diff-rename: wrap file creations in a test Matthieu Moy
2016-02-25 8:59 ` [PATCH v2 3/5] t: add tests for diff.renames (true/false/unset) Matthieu Moy
2016-02-25 8:59 ` [PATCH v2 4/5] log: introduce init_log_defaults() Matthieu Moy
2016-02-25 19:31 ` Junio C Hamano
2016-02-25 8:59 ` [PATCH v2 5/5] diff: activate diff.renames by default Matthieu Moy
2016-02-25 17:52 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqa8mr1bk7.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=Matthieu.Moy@imag$(echo .)fr \
--cc=git@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox