Subject: Re: [PATCH] convert: legitimately disable clean/smudge filter with an empty override

From: Junio C Hamano <[email-masked]>
Date: Thu, 28 Jan 2016 15:51:44 -0800

[email-masked] writes:

> -	if (ca.drv) {
> +	if (ca.drv && ca.drv->smudge && strlen(ca.drv->smudge)) {

You are not interested in its length, but if it is an empty string
or not, so I'd tweak this like so:

> +	if (ca.drv && ca.drv->smudge && *ca.drv->smudge) {