From: Junio C Hamano <gitster@pobox•com>
To: Stefan Beller <sbeller@google•com>
Cc: Mike Crowe <mac@mcrowe•com>,
"git\@vger.kernel.org" <git@vger•kernel.org>,
Jeff King <peff@peff•net>
Subject: Re: [PATCH 1/2] push: Fully test --recurse-submodules on command line overrides config
Date: Thu, 17 Dec 2015 08:41:52 -0800 [thread overview]
Message-ID: <xmqqa8p9c9in.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <CAGZ79kZpCPp6CrfknQRDObKvuNnCe2+bZwCAF8XKrkkVNS+e3w@mail.gmail.com> (Stefan Beller's message of "Wed, 16 Dec 2015 14:46:23 -0800")
Stefan Beller <sbeller@google•com> writes:
>>> This looks good to me.
>>>
>> Thanks. Does "This" refer to 1/2 alone or the whole series?
>
> Yes. :)
>
> "This" is applicable to both patches. We had the discussion on 2/2 about me
> misreading a line a few days earlier, but apart from that it looked good, too.
Thanks.
prev parent reply other threads:[~2015-12-17 16:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-01 11:49 [PATCH v3] push: add recurseSubmodules config option Mike Crowe
2015-12-02 0:40 ` Jeff King
2015-12-02 9:54 ` Mike Crowe
2015-12-02 9:56 ` [PATCH] push: Improve --recurse-submodules support Mike Crowe
2015-12-02 23:21 ` Junio C Hamano
2015-12-03 13:10 ` Mike Crowe
2015-12-03 13:10 ` [PATCH 1/2] push: Fully test --recurse-submodules on command line overrides config Mike Crowe
2015-12-03 13:10 ` [PATCH 2/2] push: Use "last one wins" convention for --recurse-submodules Mike Crowe
2015-12-04 21:04 ` Junio C Hamano
2015-12-10 23:31 ` Stefan Beller
2015-12-10 23:38 ` Junio C Hamano
2015-12-10 23:44 ` Stefan Beller
2015-12-16 20:48 ` [PATCH 1/2] push: Fully test --recurse-submodules on command line overrides config Stefan Beller
2015-12-16 22:41 ` Junio C Hamano
2015-12-16 22:46 ` Stefan Beller
2015-12-17 16:41 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqa8p9c9in.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=mac@mcrowe$(echo .)com \
--cc=peff@peff$(echo .)net \
--cc=sbeller@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox