From: Junio C Hamano <gitster@pobox•com>
To: "Nguyễn Thái Ngọc Duy" <pclouds@gmail•com>
Cc: git@vger•kernel.org, sbeller@google•com, asottile@umich•edu
Subject: Re: [PATCH 2/2] setup.c: re-fix d95138e (setup: set env $GIT_WORK_TREE when ..
Date: Fri, 04 Dec 2015 12:35:15 -0800 [thread overview]
Message-ID: <xmqqa8pqrlz0.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <1449166676-30845-2-git-send-email-pclouds@gmail.com> ("Nguyễn Thái Ngọc Duy"'s message of "Thu, 3 Dec 2015 19:17:56 +0100")
Nguyễn Thái Ngọc Duy <pclouds@gmail•com> writes:
> ... Now I conclude
> that setup-messed-by-alias is always evil. So the env restoration is
> done for _all_ commands whenever aliases are involved.
So a side effect of this is whenever an alias is involved, all
commands are re-spawned, not just the external ones but builtins as
well.
> This may be a brilliant fix, or another invitation for regressions.
;-)
next prev parent reply other threads:[~2015-12-04 20:35 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CA+dzEB=2LJXiLSTqyLw8AeHNwdQicwvEiMg=hVEX0-_s1bySpA@mail.gmail.com>
2015-11-24 2:22 ` Fwd: Git clone fails during pre-commit hook due to GIT_WORK_TREE=. (regression 2.5 -> 2.6) Anthony Sottile
2015-11-24 17:57 ` Stefan Beller
2015-11-25 20:13 ` Duy Nguyen
2015-11-30 19:01 ` Duy Nguyen
2015-11-30 20:16 ` Junio C Hamano
2015-12-01 17:59 ` Duy Nguyen
2015-12-02 17:09 ` Junio C Hamano
2015-12-03 18:17 ` [PATCH 1/2] git.c: make it clear save_env() is for alias handling only Nguyễn Thái Ngọc Duy
2015-12-03 18:17 ` [PATCH 2/2] setup.c: re-fix d95138e (setup: set env $GIT_WORK_TREE when Nguyễn Thái Ngọc Duy
2015-12-04 20:35 ` Junio C Hamano [this message]
2015-12-05 5:48 ` Duy Nguyen
2015-12-05 15:32 ` [PATCH 3/2] git.c: make sure we do not leak GIT_* to alias scripts Nguyễn Thái Ngọc Duy
2015-12-07 18:54 ` Junio C Hamano
2015-12-08 16:55 ` Duy Nguyen
2015-12-08 17:20 ` Jeff King
2015-12-08 23:55 ` Junio C Hamano
2015-12-05 19:12 ` [PATCH 2/2] setup.c: re-fix d95138e (setup: set env $GIT_WORK_TREE when Duy Nguyen
2015-12-07 18:33 ` Junio C Hamano
2015-12-20 7:50 ` [PATCH v2 0/3] nd/clear-gitenv-upon-use-of-alias Nguyễn Thái Ngọc Duy
2015-12-20 7:50 ` [PATCH v2 1/3] git.c: make it clear save_env() is for alias handling only Nguyễn Thái Ngọc Duy
2015-12-20 7:50 ` [PATCH v2 2/3] setup.c: re-fix d95138e (setup: set env $GIT_WORK_TREE when Nguyễn Thái Ngọc Duy
2015-12-20 7:50 ` [PATCH v2 3/3] git.c: make sure we do not leak GIT_* to alias scripts Nguyễn Thái Ngọc Duy
2015-12-21 21:18 ` [PATCH v2 0/3] nd/clear-gitenv-upon-use-of-alias Junio C Hamano
2015-12-22 10:57 ` Duy Nguyen
2015-12-22 11:53 ` Duy Nguyen
2015-12-22 18:13 ` Junio C Hamano
2015-12-23 9:37 ` Jeff King
2015-12-23 10:20 ` Duy Nguyen
2015-12-23 16:17 ` Eric Sunshine
2015-12-23 20:37 ` Johannes Sixt
2015-12-23 21:31 ` Jeff King
2015-12-24 9:35 ` Duy Nguyen
2015-12-29 8:12 ` Jeff King
2015-12-29 21:34 ` Junio C Hamano
2015-12-21 10:22 ` [PATCH] Revert "setup: set env $GIT_WORK_TREE when work tree is set, like $GIT_DIR" Nguyễn Thái Ngọc Duy
2015-12-21 17:28 ` Junio C Hamano
2015-12-21 18:31 ` Junio C Hamano
2015-12-22 1:06 ` Duy Nguyen
2015-12-22 21:50 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqa8pqrlz0.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=asottile@umich$(echo .)edu \
--cc=git@vger$(echo .)kernel.org \
--cc=pclouds@gmail$(echo .)com \
--cc=sbeller@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox