public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Junio C Hamano <gitster@pobox•com>
To: Michael Rappazzo <rappazzo@gmail•com>
Cc: johannes.schindelin@gmx•de, git@vger•kernel.org
Subject: Re: [PATCH v4] git-rebase--interactive.sh: add config option for custom instruction format
Date: Fri, 12 Jun 2015 13:56:35 -0700	[thread overview]
Message-ID: <xmqqa8w4d4sc.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1434075808-43453-2-git-send-email-rappazzo@gmail.com> (Michael Rappazzo's message of "Thu, 11 Jun 2015 22:23:28 -0400")

Michael Rappazzo <rappazzo@gmail•com> writes:

> A config option 'rebase.instructionFormat' can override the
> default 'oneline' format of the rebase instruction list.
>
> Since the list is parsed using the left, right or boundary mark plus
> the sha1, they are prepended to the instruction format.
>
> Signed-off-by: Michael Rappazzo <rappazzo@gmail•com>
> ---
>  Documentation/git-rebase.txt |  7 +++++++
>  git-rebase--interactive.sh   | 20 +++++++++++++++++---
>  t/t3415-rebase-autosquash.sh | 21 +++++++++++++++++++++
>  3 files changed, 45 insertions(+), 3 deletions(-)

Thanks, will replace.

The autosquash part somehow makes me feel uneasy, though.  The
feature fundamentally has to have %s as the first thing in the
format to work, but by making the format overridable, you are
potentially breaking that feature, aren't you?

next prev parent reply	other threads:[~2015-06-12 20:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-12  2:23 [PATCH v4] git-rebase--interactive.sh: add config option for custom instruction format Michael Rappazzo
2015-06-12  2:23 ` Michael Rappazzo
2015-06-12 20:56   ` Junio C Hamano [this message]
2015-06-12 21:12     ` Mike Rappazzo
2015-06-12 22:05       ` Junio C Hamano
2015-06-12 22:15         ` Mike Rappazzo
2015-06-12 22:36           ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqa8w4d4sc.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=johannes.schindelin@gmx$(echo .)de \
    --cc=rappazzo@gmail$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox