Subject: Re: [RFC/WIP PATCH 02/11] upload-pack: only accept capabilities on the first "want" line

From: Junio C Hamano <[email-masked]>
Date: Tue, 26 May 2015 15:17:33 -0700

Stefan Beller <[email-masked]> writes:

> From: Nguyễn Thái Ngọc Duy <[email-masked]>
>
> pack-protocol.txt says so and fetch-pack also follows it even though
> upload-pack is a bit lax. Fix it.

Hmm, I actually think the .txt file unsuccessfully tried to close
the barn door after horse has long left.  The existing clients that
read protocol capabilities keep the last-read copy and then
overwrite it when a new one came, which is why we couldn't update
the protocol by sending only incremental changes, etc. without
breaking existing clients.

I somehow thought that we already discussed why this was bad the
first time Duy's patch was posted, but apparently we didn't.

X-<.