public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Junio C Hamano <gitster@pobox•com>
To: karthik nayak <karthik.188@gmail•com>
Cc: Eric Sunshine <sunshine@sunshineco•com>, Git List <git@vger•kernel.org>
Subject: Re: [PATCH v10 4/4] t1006: add tests for git cat-file --allow-unknown-type
Date: Tue, 05 May 2015 21:37:14 -0700	[thread overview]
Message-ID: <xmqqa8xicoed.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <55482984.1000600@gmail.com> (karthik nayak's message of "Tue, 05 May 2015 07:53:00 +0530")

karthik nayak <karthik.188@gmail•com> writes:

>>> +    test_expect_success "Type of $type is correct using --allow-unknown-type" '
>>> +       echo $type >expect &&
>>> +    git cat-file -t --allow-unknown-type $sha1 >actual &&
>>
>> Indentation is still botched in this test and the next one (as
>> mentioned previously [1]).
>>
>> [1]: http://article.gmane.org/gmane.comp.version-control.git/268005
> It only seems to have affected the test file, I made sure the
> indentation was correct after your previous suggestion, I have to see
> why this is happening. Thanks

Any other updates planned for this series?  If it were only the
indentation in the tests, I could locally amend to skip one
round-trip if I wanted to hurry, and that is why I am asking, as I
am planning to start merging topics down to 'next' soonish...

Thanks.

next prev parent reply	other threads:[~2015-05-06  4:37 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-03 14:28 [PATCH v10 0/4] cat-file: add support for "-allow-unknown-type" karthik nayak
2015-05-03 14:29 ` [PATCH v10 1/4] sha1_file: support reading from a loose object of unknown type Karthik Nayak
2015-05-03 14:30   ` [PATCH v10 2/4] cat-file: make the options mutually exclusive Karthik Nayak
2015-05-03 14:30   ` [PATCH v10 3/4] cat-file: teach cat-file a '--allow-unknown-type' option Karthik Nayak
2015-05-05  1:29     ` Eric Sunshine
2015-05-03 14:30   ` [PATCH v10 4/4] t1006: add tests for git cat-file --allow-unknown-type Karthik Nayak
2015-05-05  1:33     ` Eric Sunshine
2015-05-05  2:23       ` karthik nayak
2015-05-06  4:37         ` Junio C Hamano [this message]
2015-05-04 23:34   ` [PATCH v10 1/4] sha1_file: support reading from a loose object of unknown type Eric Sunshine
2015-05-05  2:21     ` karthik nayak
2015-05-04  0:10 ` [PATCH v10 0/4] cat-file: add support for "-allow-unknown-type" Junio C Hamano
2015-05-04  0:14   ` Junio C Hamano
2015-05-04  2:55     ` Eric Sunshine
2015-05-04  3:30       ` Eric Sunshine
2015-05-04 13:31         ` karthik nayak
2015-05-06 13:37         ` karthik nayak
2015-05-06 17:16           ` Junio C Hamano
2015-05-07  3:34             ` Karthik Nayak
2015-05-07 18:35               ` Junio C Hamano
2015-05-04 13:30     ` karthik nayak
2015-05-04 20:57       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqa8xicoed.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=karthik.188@gmail$(echo .)com \
    --cc=sunshine@sunshineco$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox