From: Junio C Hamano <gitster@pobox•com>
To: Sitaram Chamarty <sitaramc@gmail•com>
Cc: "git\@vger.kernel.org" <git@vger•kernel.org>
Subject: Re: GIT_PUSH_CERT* env vars and update/post-update hooks...
Date: Mon, 29 Dec 2014 08:36:46 -0800 [thread overview]
Message-ID: <xmqqa9261kgx.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <549A1D8A.3020106@gmail.com> (Sitaram Chamarty's message of "Wed, 24 Dec 2014 07:27:30 +0530")
Sitaram Chamarty <sitaramc@gmail•com> writes:
> Any chance I could persuade you to set the GIT_PUSH_CERT* environment
> variables for the update (and post-update) hooks also?
I do not think of a fundamental reason why we shouldn't give these
environment variables to update or other hooks. It should just be
the matter of calling prepare_push_cert_sha1() on the child_process
struct used to run the hooks you want.
> [1]: because it's nice to *selectively* reject refs when more than one
> ref is pushed at the same time; pre-receive is "all or none".
It cuts both ways; inside "update", your "selective" rejection
cannot make the decision with the whole picture (you only have a
peephole into individual changes). "post-receive" sees the whole
picture, but it has to say all-or-none. Neither is ideal if you
truly want a useful "selective".
prev parent reply other threads:[~2014-12-29 16:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-24 1:57 GIT_PUSH_CERT* env vars and update/post-update hooks Sitaram Chamarty
2014-12-29 16:36 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqa9261kgx.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=sitaramc@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox