Subject: Re: [PATCH 4/5] push.c: add an --atomic-push argument

From: Junio C Hamano <[email-masked]>
Date: Mon, 15 Dec 2014 13:50:16 -0800

Stefan Beller <[email-masked]> writes:

> From: Ronnie Sahlberg <[email-masked]>
>
> Add a command line argument to the git push command to request atomic
> pushes.
>
> Signed-off-by: Ronnie Sahlberg <[email-masked]>
> Signed-off-by: Stefan Beller <[email-masked]>
> ---

Makes sense, modulo a nit.

> +--atomic-push::
> +	Using atomic push. If atomic push is negotiated with the server
> +	then any push covering multiple refs will be atomic. Either all
> +	refs are updated, or on error, no refs are updated. If the server
> +	does not support atomic pushes the push will fail.

"git push --atomic-push"?  Why should one need to repeat the word?

>  		OPT_BIT(0, "signed", &flags, N_("GPG sign the push"), TRANSPORT_PUSH_CERT),
> +		OPT_BIT(0, "atomic-push", &flags, N_("use atomic push, if available"),
> +			TRANSPORT_ATOMIC_PUSH),

Contrast between the two.  It isn't "git push --signed-push", either ;-)