From: Junio C Hamano <gitster@pobox•com>
To: "Jakub Narębski" <jnareb@gmail•com>
Cc: Jonathan Nieder <jrnieder@gmail•com>,
git@vger•kernel.org, Roland Mas <lolando@debian•org>
Subject: Re: [PATCH] Update gitweb.perl to current CGI.pm API
Date: Thu, 16 Oct 2014 12:36:54 -0700 [thread overview]
Message-ID: <xmqqa94vu7qh.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <87lhogzeq0.fsf@placard.fr.eu.org> (Roland Mas's message of "Thu, 16 Oct 2014 08:54:47 +0200")
Looks sensible to me; Jakub, ack?
Roland Mas <lolando@debian•org> writes:
> Hi all,
>
> This simple two-line patch fixes a bug that makes gitweb unusable on
> systems where the installed CGI.pm is version 4.04 or later (such as on
> Debian unstable). That version removed the startform method, which had
> previously been deprecated in favour of start_form since 2009.
>
> I don't have any specific tests for that change, but it does help
> fixing the testsuite of FusionForge (which includes a test of its Git
> plugin, involving gitweb).
>
> For reference, this is Debian bug #765525 (http://bugs.debian.org/765525).
>
> (I'm not subscribed to the git@vger mailing-list; please Cc me on
> replies.)
>
> Thanks,
>
> Roland.
>
> From 1b74cfb8568927a307f165e428455789398f6d61 Mon Sep 17 00:00:00 2001
> From: Roland Mas <lolando@debian•org>
> Date: Thu, 16 Oct 2014 00:05:25 +0200
> Subject: [PATCH] Update gitweb.perl to current CGI.pm API
>
> CGI.pm 4.04 removed the startform method, which had previously been
> deprecated in favour of start_form. Updated gitweb.perl accordingly.
>
> Signed-off-by: Roland Mas <lolando@debian•org>
> ---
> gitweb/gitweb.perl | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index a9f57d6..ccf7516 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -4100,7 +4100,7 @@ sub print_search_form {
> if ($use_pathinfo) {
> $action .= "/".esc_url($project);
> }
> - print $cgi->startform(-method => "get", -action => $action) .
> + print $cgi->start_form(-method => "get", -action => $action) .
> "<div class=\"search\">\n" .
> (!$use_pathinfo &&
> $cgi->input({-name=>"p", -value=>$project, -type=>"hidden"}) . "\n") .
> @@ -5510,7 +5510,7 @@ sub git_project_search_form {
> }
>
> print "<div class=\"projsearch\">\n";
> - print $cgi->startform(-method => 'get', -action => $my_uri) .
> + print $cgi->start_form(-method => 'get', -action => $my_uri) .
> $cgi->hidden(-name => 'a', -value => 'project_list') . "\n";
> print $cgi->hidden(-name => 'pf', -value => $project_filter). "\n"
> if (defined $project_filter);
next prev parent reply other threads:[~2014-10-16 19:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-16 6:54 [PATCH] Update gitweb.perl to current CGI.pm API Roland Mas
2014-10-16 19:36 ` Junio C Hamano [this message]
[not found] ` <CANQwDwdm6aMVC7U+nbbtS=J8M2fYOk_MECt_1=NX=pXdt06YjQ@mail.gmail.com>
2014-10-16 20:18 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqa94vu7qh.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=jnareb@gmail$(echo .)com \
--cc=jrnieder@gmail$(echo .)com \
--cc=lolando@debian$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox