From: Junio C Hamano <gitster@pobox•com>
To: Jeff King <peff@peff•net>
Cc: Pasha Bolokhov <pasha.bolokhov@gmail•com>,
Git Mailing List <git@vger•kernel.org>,
Duy Nguyen <pclouds@gmail•com>
Subject: Re: [PATCH] Improve function dir.c:trim_trailing_spaces()
Date: Fri, 30 May 2014 11:45:36 -0700 [thread overview]
Message-ID: <xmqqa99z9kbz.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20140530020444.GH28683@sigill.intra.peff.net> (Jeff King's message of "Thu, 29 May 2014 22:04:44 -0400")
Jeff King <peff@peff•net> writes:
> On Thu, May 29, 2014 at 02:34:33PM -0700, Pasha Bolokhov wrote:
>
>> > However, I doubt it makes that much of a difference in practice, so
>> > unless it's measurable, I would certainly go with the version that is
>> > more readable (and correct, of course).
>>
>> Sorry, just to recap, you would go with the existing version
>> (which needs correction), or with the one that is being suggested? (I
>> agree I can format the style a tiny bit better in the latter one)
>
> I actually think the original left-to-right is a little easier to
> follow, but I do not feel strongly. I mainly meant "argue based on
> readability and correctness, do not argue based on speed".
Sensible.
> I'd be OK with either, though I have a slight preference for the first,
> just because I find the "bslash ^= 1" bit of yours, while clever, a bit
> hard to follow.
FWIW, I think I agree.
next prev parent reply other threads:[~2014-05-30 18:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-28 23:45 [PATCH] Improve function dir.c:trim_trailing_spaces() Pasha Bolokhov
2014-05-29 20:13 ` Jeff King
2014-05-29 21:34 ` Pasha Bolokhov
2014-05-30 2:04 ` Jeff King
2014-05-30 18:45 ` Junio C Hamano [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-05-31 15:21 Pasha Bolokhov
2014-06-02 6:47 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqa99z9kbz.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=pasha.bolokhov@gmail$(echo .)com \
--cc=pclouds@gmail$(echo .)com \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox