public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Junio C Hamano <gitster@pobox•com>
To: Uwe Storbeck <uwe@ibr•ch>
Cc: git@vger•kernel.org
Subject: Re: [PATCH v2] rebase -i: replace an echo command by printf
Date: Mon, 17 Mar 2014 12:22:36 -0700	[thread overview]
Message-ID: <xmqqa9coeikj.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20140314235642.GA6917@ibr.ch> (Uwe Storbeck's message of "Sat, 15 Mar 2014 00:56:43 +0100")

Uwe Storbeck <uwe@ibr•ch> writes:

> to avoid shell dependent behavior.

Please do not start the body of the log message half-sentence.  The
title ought to be a freestanding "title", not just a beginning half
of a sentence that needs to be read with the rest to be understood.

Something like this, perhaps.

    Subject: [PATCH] rebase -i: do not "echo" random user-supplied strings

    In some places we "echo" a string that come from a commit log message,
    which may have a backslash sequence that is interpreted by shells
    (POSIX.1 allows this), most notably "dash".

    A commit message which contains the string '\n' (or ends with the
    string '\c') may result in a garbage line in the todo list of an
    interactive rebase which causes the rebase to fail.

Will tentatively queue with the above rewrite, but if you feel
strongly, please send an replacement.

Thanks.

next prev parent reply	other threads:[~2014-03-17 19:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-14 23:56 [PATCH v2] rebase -i: replace an echo command by printf Uwe Storbeck
2014-03-17 19:22 ` Junio C Hamano [this message]
2014-03-18  0:10   ` Uwe Storbeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqa9coeikj.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=uwe@ibr$(echo .)ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox