From: Junio C Hamano <gitster@pobox•com>
To: Jonathan Nieder <jrnieder@gmail•com>
Cc: Erik Faye-Lund <kusmabite@gmail•com>,
git@vger•kernel.org, msysgit@googlegroups•com,
Ilari Liusvaara <ilari.liusvaara@elisanet•fi>
Subject: Re: [PATCH 1/2] prefer xwrite instead of write
Date: Fri, 17 Jan 2014 12:07:15 -0800 [thread overview]
Message-ID: <xmqqa9euwex8.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20140117200236.GA18964@google.com> (Jonathan Nieder's message of "Fri, 17 Jan 2014 12:02:36 -0800")
Jonathan Nieder <jrnieder@gmail•com> writes:
> Junio C Hamano wrote:
>> Jonathan Nieder <jrnieder@gmail•com> writes:
>
>>> Shouldn't this use write_in_full() to avoid a silently truncated result? (*)
>>
>> Meaning this? If so, I think it makes sense.
> [...]
>> - if (xwrite(fd, out.buf, out.len) < 0)
>> + if (write_in_full(fd, out.buf, out.len) != out.len)
>
> Yes. Either '< 0' or '!= out.len' would work fine here, since
> write_in_full is defined to always either write the full 'count'
> bytes or return an error.
An unrelated tangent but we may want to fix majority of callers that
do not seem to know that ;-)
--
--
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.
You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups•com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups•com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en
---
You received this message because you are subscribed to the Google Groups "msysGit" group.
To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups•com.
For more options, visit https://groups.google.com/groups/opt_out.
prev parent reply other threads:[~2014-01-17 20:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-17 14:17 [PATCH 1/2] prefer xwrite instead of write Erik Faye-Lund
2014-01-17 14:17 ` [PATCH 2/2] mingw: remove mingw_write Erik Faye-Lund
2014-01-17 18:21 ` [PATCH 1/2] prefer xwrite instead of write Jonathan Nieder
2014-01-17 19:07 ` Junio C Hamano
2014-01-17 19:08 ` Erik Faye-Lund
2014-01-17 20:02 ` Jonathan Nieder
2014-01-17 20:07 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqa9euwex8.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=ilari.liusvaara@elisanet$(echo .)fi \
--cc=jrnieder@gmail$(echo .)com \
--cc=kusmabite@gmail$(echo .)com \
--cc=msysgit@googlegroups$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox