From: Junio C Hamano <gitster@pobox•com>
To: Ramkumar Ramachandra <artagnon@gmail•com>
Cc: Git List <git@vger•kernel.org>, Jeff King <peff@peff•net>
Subject: Re: [PATCH 2/2] format-patch: introduce format.defaultTo
Date: Mon, 06 Jan 2014 12:06:51 -0800 [thread overview]
Message-ID: <xmqqa9f8j2n8.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CALkWK0kZn44x98td9YXNT5VfhVs=ueeSty9M7Vh08bdoGjGQYg@mail.gmail.com> (Ramkumar Ramachandra's message of "Tue, 7 Jan 2014 00:19:02 +0530")
Ramkumar Ramachandra <artagnon@gmail•com> writes:
> Junio C Hamano wrote:
>> - why is a single branch name sufficient?
>
> It does accept a <revision>, so any form is allowed; but why would
> anyone want that in a format.defaultTo? I'm not sure we want to impose
> an artificial restriction on the configuration variable though.
I meant "a single branch" as opposed to "depending on what branch
you are sending out, you may have to use a different upstream
starting point", and a single "format.defaultTo" that does not read
what your HEAD currently points at may not be enough.
Unless you set @{u} to this new configuration, in which case the
choice becomes dynamic depending on the current branch, but
- if that is the only sane choice based on the current branch, why
not use that as the default without having to set the
configuration?
- Or if that is still insufficient, don't we need branch.*.forkedFrom
that is different from branch.*.merge, so that different branches
you want to show "format-patch" output can have different
reference points?
After all, "format-patch" to send things out to upstream is like
asking the other side to do a "rebase" you would do in your
repository, so whatever "git rebase" that were too lazy to specify
what the fork point was when applying may be a reasonable type-saver
default. Yes, sometimes people need to rebase onto somewhere they
did not fork from, but that is why they can give explicit $upstream
and $onto to the command---I do not think it is any different for
"format-patch".
next prev parent reply other threads:[~2014-01-06 20:07 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-06 17:18 [PATCH 0/2] Minor convinience feature: format.defaultTo Ramkumar Ramachandra
2014-01-06 17:18 ` [PATCH 1/2] completion: complete format.coverLetter Ramkumar Ramachandra
2014-01-07 11:24 ` Ramkumar Ramachandra
2014-01-06 17:18 ` [PATCH 2/2] format-patch: introduce format.defaultTo Ramkumar Ramachandra
2014-01-06 18:35 ` Jonathan Nieder
2014-01-06 19:02 ` Ramkumar Ramachandra
2014-01-06 18:42 ` Junio C Hamano
2014-01-06 18:49 ` Ramkumar Ramachandra
2014-01-06 20:06 ` Junio C Hamano [this message]
2014-01-06 20:18 ` Jeff King
2014-01-06 20:29 ` John Szakmeister
2014-01-06 20:42 ` Jonathan Nieder
2014-01-06 21:13 ` John Szakmeister
2014-01-06 21:37 ` Junio C Hamano
2014-01-06 22:54 ` Ramkumar Ramachandra
2014-01-07 0:42 ` John Szakmeister
2014-01-07 16:47 ` Ramkumar Ramachandra
2014-01-06 20:43 ` Jeff King
2014-01-06 20:38 ` Junio C Hamano
2014-01-06 20:55 ` Jeff King
2014-01-06 21:21 ` Junio C Hamano
2014-01-06 22:10 ` Ramkumar Ramachandra
2014-01-07 20:56 ` Jeff King
2014-01-07 21:07 ` Junio C Hamano
2014-01-07 21:24 ` Jeff King
2014-01-07 22:06 ` Junio C Hamano
2014-01-07 22:17 ` Jeff King
2014-01-07 22:27 ` Junio C Hamano
2014-04-10 19:17 ` Felipe Contreras
2014-01-06 21:59 ` Ramkumar Ramachandra
2014-01-06 22:22 ` Junio C Hamano
2014-01-06 22:47 ` Ramkumar Ramachandra
2014-01-07 21:06 ` Jeff King
2014-01-07 21:25 ` Ramkumar Ramachandra
2014-01-07 21:30 ` Jeff King
2014-04-10 19:20 ` Felipe Contreras
2014-01-06 17:25 ` [PATCH 0/2] Minor convinience feature: format.defaultTo Ramkumar Ramachandra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqa9f8j2n8.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=artagnon@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox