From: Junio C Hamano <gitster@pobox•com>
To: Leon Michalak <leonmichalak6@gmail•com>
Cc: git@vger•kernel.org, Jeff King <peff@peff•net>,
phillip.wood@dunelm•org.uk
Subject: Re: Discussion for interactive --patch commands to get --unified support
Date: Fri, 02 May 2025 11:36:21 -0700 [thread overview]
Message-ID: <xmqqbjsavp0a.fsf@gitster.g> (raw)
In-Reply-To: <CAP9jKjEbb_ABmGmLNwn=ruh+BOR73QDqtzF-cCYv40cE47fEGQ@mail.gmail.com> (Leon Michalak's message of "Fri, 2 May 2025 18:13:15 +0100")
Leon Michalak <leonmichalak6@gmail•com> writes:
> This is what I have been using currently although the perfectionist in
> me says that a user could pass `--unified=-1` and the code would treat
> that as if nothing was passed by the user.
The command line parser and corresponding config parser callback can
be careful to check the value they get from the end user to avoid
that, can't they?
In any case, it is PEBKAC when the end-users do that, and they
cannot complain about their --unified=-1 are ignored. We do not
have to care, and can just tell them "Don't do that, then."
prev parent reply other threads:[~2025-05-02 18:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-29 9:16 Discussion for interactive --patch commands to get --unified support Leon Michalak
2025-04-29 16:48 ` Junio C Hamano
2025-04-29 22:09 ` Jeff King
2025-04-30 8:04 ` Leon Michalak
2025-04-30 14:40 ` Junio C Hamano
2025-05-02 14:33 ` Phillip Wood
2025-05-02 14:39 ` Phillip Wood
2025-05-02 16:14 ` Leon Michalak
2025-05-02 16:23 ` Leon Michalak
2025-05-02 16:57 ` Junio C Hamano
2025-05-02 17:13 ` Leon Michalak
2025-05-02 18:36 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqbjsavp0a.fsf@gitster.g \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=leonmichalak6@gmail$(echo .)com \
--cc=peff@peff$(echo .)net \
--cc=phillip.wood@dunelm$(echo .)org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox