Subject: What's cooking in git.git (Nov 2024, #04; Fri, 8)

From: Junio C Hamano <[email-masked]>
Date: Fri, 08 Nov 2024 17:03:12 +0900

Here are the topics that have been cooking in my tree.  Commits
prefixed with '+' are in 'next' (being in 'next' is a sign that a
topic is stable enough to be used and are candidate to be in a
future release).  Commits prefixed with '-' are only in 'seen', and
aren't considered "accepted" at all and may be annotated with an URL
to a message that raises issues but they are no means exhaustive.  A
topic without enough support may be discarded after a long period of
no activity (of course they can be resubmit when new interests
arise).

It has been a bit longer than usual since the last issue of the
"What's cooking report".  We still have way too many topics that are
not sufficiently reviewed.  Help is greatly appreciated.

Copies of the source code to Git live in many repositories, and the
following is a list of the ones I push into or their mirrors.  Some
repositories have only a subset of branches.

With maint, master, next, seen, todo:

	git://git.kernel.org/pub/scm/git/git.git/
	git://repo.or.cz/alt-git.git/
	https://kernel.googlesource.com/pub/scm/git/git/
	https://github.com/git/git/
	https://gitlab.com/git-scm/git/

With all the integration branches and topics broken out:

	https://github.com/gitster/git/

Even though the preformatted documentation in HTML and man format
are not sources, they are published in these repositories for
convenience (replace "htmldocs" with "manpages" for the manual
pages):

	git://git.kernel.org/pub/scm/git/git-htmldocs.git/
	https://github.com/gitster/git-htmldocs.git/

Release tarballs are available at:

	https://www.kernel.org/pub/software/scm/git/

--------------------------------------------------
[Graduated to 'master']

* cw/config-extensions (2024-10-22) 1 commit
  (merged to 'next' on 2024-10-30 at 875fa0b619)
 + doc: consolidate extensions in git-config documentation
 (this branch is used by cw/worktree-extension.)

 Centralize documentation for repository extensions into a single place.
 source: <[email-masked]>

* jk/left-right-bitmap (2024-11-01) 1 commit
  (merged to 'next' on 2024-11-01 at f1d0c395f5)
 + rev-list: skip bitmap traversal for --left-right

 When called with '--left-right' and '--use-bitmap-index', 'rev-list'
 will produce output without any left/right markers, which has been
 corrected.
 source: <[email-masked]>

* kn/arbitrary-suffixes (2024-10-24) 1 commit
  (merged to 'next' on 2024-10-30 at 3eedf30c6c)
 + CodingGuidelines: discourage arbitrary suffixes in function names

 Update the project's CodingGuidelines to discourage naming functions
 with a "_1()" suffix.
 source: <[email-masked]>

* kn/ci-clang-format-tidy (2024-10-18) 2 commits
  (merged to 'next' on 2024-10-30 at d063e828d5)
 + clang-format: align consecutive macro definitions
 + clang-format: re-adjust line break penalties

 Updates the '.clang-format' to match project conventions.
 source: <[email-masked]>

* ps/upgrade-clar (2024-10-21) 5 commits
  (merged to 'next' on 2024-10-30 at b8b092bb78)
 + cmake: set up proper dependencies for generated clar headers
 + cmake: fix compilation of clar-based unit tests
 + Makefile: extract script to generate clar declarations
 + Makefile: adjust sed command for generating "clar-decls.h"
 + t/unit-tests: update clar to 206accb
 (this branch is used by ps/build.)

 Buildfix and upgrade of Clar to a newer version.
 source: <[email-masked]>

--------------------------------------------------
[New Topics]

* ps/reftable-iterator-reuse (2024-11-05) 9 commits
 - refs/reftable: reuse iterators when reading refs
 - reftable/merged: drain priority queue on reseek
 - reftable/stack: add mechanism to notify callers on reload
 - refs/reftable: refactor reflog expiry to use reftable backend
 - refs/reftable: refactor reading symbolic refs to use reftable backend
 - refs/reftable: read references via `struct reftable_backend`
 - refs/reftable: handle reloading stacks in the reftable backend
 - refs/reftable: encapsulate reftable stack
 - Merge branch 'ps/reftable-detach' into HEAD
 (this branch uses ps/reftable-detach.)

 Optimize reading random references out of the reftable backend by
 allowing reuse of iterator objects.

 Needs review.
 source: <[email-masked]>

* jc/move-is-bare-repository-cfg-variable-to-repo (2024-11-07) 3 commits
 - repository: BUG when is_bare_cfg is not initialized
 - setup: initialize is_bare_cfg
 - git: remove is_bare_repository_cfg global variable

 Code rewrite to turn the is_bare_repository_cfg global variable
 into a member in the the_repo singleton repository object.

 Waiting for response to reviews.
 source: <[email-masked]>

* jk/describe-perf (2024-11-07) 4 commits
 - describe: stop traversing when we run out of names
 - describe: stop digging for max_candidates+1
 - t/perf: add tests for git-describe
 - t6120: demonstrate weakness in disjoint-root handling

 "git describe" optimization.

 Expecting a reroll.
 cf <[email-masked]>
 source: <[email-masked]>

* js/range-diff-diff-merges (2024-11-08) 1 commit
 - range-diff: optionally include merge commits' diffs in the analysis

 "git range-diff" learned to optionally show and compare merge
 commits in the ranges being compared, with the --diff-merges
 option.

 Waiting for response to reviews.
 source: <[email-masked]>

* ps/leakfixes-part-10 (2024-11-07) 27 commits
 - t: remove TEST_PASSES_SANITIZE_LEAK annotations
 - test-lib: unconditionally enable leak checking
 - t: remove unneeded !SANITIZE_LEAK prerequisites
 - t: mark some tests as leak free
 - t5601: work around leak sanitizer issue
 - git-compat-util: drop `UNLEAK()` annotation
 - t/helper: fix leaking commit graph in "read-graph" subcommand
 - builtin/branch: fix leaking sorting options
 - builtin/init-db: fix leaking directory paths
 - builtin/help: fix leaks in `check_git_cmd()`
 - help: fix leaking return value from `help_unknown_cmd()`
 - help: fix leaking `struct cmdnames`
 - help: refactor to not use globals for reading config
 - builtin/sparse-checkout: fix leaking sanitized patterns
 - split-index: fix memory leak in `move_cache_to_base_index()`
 - git: refactor builtin handling to use a `struct strvec`
 - git: refactor alias handling to use a `struct strvec`
 - strvec: introduce new `strvec_splice()` function
 - line-log: fix leak when rewriting commit parents
 - bisect: fix various cases where we leak commit list items
 - bisect: fix leaking commit list items in `check_merge_base()`
 - bisect: fix multiple leaks in `bisect_next_all()`
 - bisect: fix leaking `current_bad_oid`
 - bisect: fix leaking string in `handle_bad_merge_base()`
 - bisect: fix leaking good/bad terms when reading multipe times
 - builtin/blame: fix leaking blame entries with `--incremental`
 - Merge branch 'ps/leakfixes-part-9' into ps/leakfixes-part-10
 (this branch uses ps/leakfixes-part-9.)

 Leakfixes.

 Needs review.
 source: <[email-masked]>

--------------------------------------------------
[Cooking]

* ak/t1016-style (2024-11-03) 1 commit
  (merged to 'next' on 2024-11-05 at ee100e90d3)
 + t1016: clean up style

 Test modernization.

 Will merge to 'master'.
 source: <[email-masked]>

* en/shallow-exclude-takes-a-ref-fix (2024-11-04) 2 commits
  (merged to 'next' on 2024-11-05 at 8c5d52930b)
 + doc: correct misleading descriptions for --shallow-exclude
 + upload-pack: fix ambiguous error message

 The "--shallow-exclude=<ref>" option to various history transfer
 commands takes a ref, not an arbitrary revision.

 Will merge to 'master'.
 source: <[email-masked]>

* kh/sequencer-comment-char (2024-10-23) 1 commit
 - sequencer: comment checked-out branch properly

 The sequencer failed to honor core.commentString in some places.

 Expecting a reroll.
 cf. <[email-masked]>
 source: <[email-masked]>

* ds/full-name-hash (2024-11-04) 7 commits
 - test-tool: add helper for name-hash values
 - pack-objects: disable --full-name-hash when shallow
 - p5313: add size comparison test
 - git-repack: update usage to match docs
 - pack-objects: add GIT_TEST_FULL_NAME_HASH
 - repack: add --full-name-hash option
 - pack-objects: add --full-name-hash option

 "git pack-objects" and its wrapper "git repack" learned an option
 to use an alternative path-hash function to improve delta-base
 selection to produce a packfile with deeper history than window
 size.

 Needs review.
 source: <[email-masked]>

* jt/repack-local-promisor (2024-11-03) 5 commits
 - fixup! index-pack: repack local links into promisor packs
 - index-pack: repack local links into promisor packs
 - t5300: move --window clamp test next to unclamped
 - t0410: use from-scratch server
 - t0410: make test description clearer

 "git gc" discards any objects that are outside promisor packs that
 are referred to by an object in a promisor pack, and we do not
 refetch them from the promisor at runtime, resulting an unusable
 repository.  Work it around by including these objects in the
 referring promisor pack at the receiving end of the fetch.

 Will merge to 'next' when the CI breakage fixup is addressed.
 Breaks CI (with a known fix).
 source: <[email-masked]>

* ds/path-walk-1 (2024-10-31) 6 commits
 - path-walk: mark trees and blobs as UNINTERESTING
 - path-walk: visit tags and cached objects
 - path-walk: allow consumer to specify object types
 - t6601: add helper for testing path-walk API
 - test-lib-functions: add test_cmp_sorted
 - path-walk: introduce an object walk by path

 Introduce a new API to visit objects in batches based on a common
 path, or by type.

 Under discussion.
 cf. <ZyUqr/[email-masked]>
 source: <[email-masked]>

* bc/ancient-ci (2024-11-01) 3 commits
 - Add additional CI jobs to avoid accidental breakage
 - ci: remove clause for Ubuntu 16.04
 - gitlab-ci: switch from Ubuntu 16.04 to 20.04

 Drop support for ancient environments in various CI jobs.

 Needs review.
 source: <[email-masked]>

* cw/worktree-extension (2024-11-01) 9 commits
 - worktree: refactor `repair_worktree_after_gitdir_move()`
 - worktree: add relative cli/config options to `repair` command
 - worktree: add relative cli/config options to `move` command
 - worktree: add relative cli/config options to `add` command
 - worktree: add `write_worktree_linking_files()` function
 - worktree: refactor infer_backlink return
 - worktree: add `relativeWorktrees` extension
 - setup: correctly reinitialize repository version
 - Merge branch 'cw/config-extensions' into cw/worktree

 Introduce a new repository extension to prevent older Git versions
 from mis-interpreting worktrees created with relative paths.

 Needs review.
 source: <[email-masked]>

* kh/bundle-docs (2024-11-08) 4 commits
 - Documentation/git-bundle.txt: discuss naïve backups
 - Documentation/git-bundle.txt: mention --all in spec. refs
 - Documentation/git-bundle.txt: remove old `--all` example
 - Documentation/git-bundle.txt: mention full backup example

 Documentation improvements to more prominently call out the use of
 '--all' when creating bundles.

 Will merge to 'next'?
 source: <[email-masked]>

* as/show-index-uninitialized-hash (2024-11-04) 2 commits
 - t5300: add test for 'show-index --object-format'
 - show-index: fix uninitialized hash function

 Regression fix for 'show-index' when run outside of a repository.

 Expecting a reroll.
 cf. <[email-masked]>
 source: <[email-masked]>

* ps/mingw-rename (2024-11-06) 3 commits
  (merged to 'next' on 2024-11-06 at 6dd2fffec7)
 + compat/mingw: support POSIX semantics for atomic renames
 + compat/mingw: allow deletion of most opened files
 + compat/mingw: share file handles created via `CreateFileW()`

 Teaches the MinGW compatibility layer to support POSIX semantics for
 atomic renames when other process(es) have a file opened at the
 destination path.

 Will merge to 'master'.
 cf. <[email-masked]>
 source: <[email-masked]>

* ps/reftable-detach (2024-10-23) 8 commits
 - reftable/system: provide thin wrapper for lockfile subsystem
 - reftable/stack: drop only use of `get_locked_file_path()`
 - reftable/system: provide thin wrapper for tempfile subsystem
 - reftable/stack: stop using `fsync_component()` directly
 - reftable/system: stop depending on "hash.h"
 - reftable: explicitly handle hash format IDs
 - reftable/system: move "dir.h" to its only user
 - Merge branch 'ps/reftable-strbuf' into ps/reftable-detach
 (this branch is used by ps/reftable-iterator-reuse.)

 Isolates the reftable subsystem from the rest of Git's codebase by
 using fewer pieces of Git's infrastructure.

 Needs review.
 source: <[email-masked]>

* km/config-remote-by-name (2024-10-21) 1 commit
 - config: support remote name in includeIf.hasconfig condition

 Support conditionally including configuration by remote name, instead
 of just URL.

 Needs review.
 source: <[email-masked]>

* ps/leakfixes-part-9 (2024-11-04) 22 commits
  (merged to 'next' on 2024-11-05 at 0260dbd8bd)
 + list-objects-filter-options: work around reported leak on error
 + builtin/merge: release output buffer after performing merge
 + dir: fix leak when parsing "status.showUntrackedFiles"
 + t/helper: fix leaking buffer in "dump-untracked-cache"
 + t/helper: stop re-initialization of `the_repository`
 + sparse-index: correctly free EWAH contents
 + dir: release untracked cache data
 + combine-diff: fix leaking lost lines
 + builtin/tag: fix leaking key ID on failure to sign
 + transport-helper: fix leaking import/export marks
 + builtin/commit: fix leaking cleanup config
 + trailer: fix leaking strbufs when formatting trailers
 + trailer: fix leaking trailer values
 + builtin/commit: fix leaking change data contents
 + upload-pack: fix leaking URI protocols
 + pretty: clear signature check
 + diff-lib: fix leaking diffopts in `do_diff_cache()`
 + revision: fix leaking bloom filters
 + builtin/grep: fix leak with `--max-count=0`
 + grep: fix leak in `grep_splice_or()`
 + t/helper: fix leaks in "reach" test tool
 + builtin/ls-remote: plug leaking server options
 (this branch is used by ps/leakfixes-part-10.)

 More leakfixes.

 Will merge to 'master'.
 source: <[email-masked]>

* y5/diff-pager (2024-10-21) 1 commit
 - diff: setup pager only before diff contents truly ready

 Delay setting up the pager in 'git diff' until after the diff contents
 itself is fully prepared.

 Needs review.
 source: <[email-masked]>

* la/trailer-info (2024-10-14) 1 commit
 - trailer: spread usage of "trailer_block" language

 Refactoring.

 Needs review.
 source: <[email-masked]>

* bc/drop-ancient-libcurl-and-perl (2024-10-23) 12 commits
 - gitweb: make use of s///r
 - Require Perl 5.26.0
 - INSTALL: document requirement for libcurl 7.61.0
 - git-curl-compat: remove check for curl 7.56.0
 - git-curl-compat: remove check for curl 7.53.0
 - git-curl-compat: remove check for curl 7.52.0
 - git-curl-compat: remove check for curl 7.44.0
 - git-curl-compat: remove check for curl 7.43.0
 - git-curl-compat: remove check for curl 7.39.0
 - git-curl-compat: remove check for curl 7.34.0
 - git-curl-compat: remove check for curl 7.25.0
 - git-curl-compat: remove check for curl 7.21.5

 Drop support for older libcURL and Perl.

 Under discussion.
 source: <[email-masked]>

* es/oss-fuzz (2024-10-16) 3 commits
 - fuzz: port fuzz-url-decode-mem from OSS-Fuzz
 - fuzz: port fuzz-parse-attr-line from OSS-Fuzz
 - fuzz: port fuzz-credential-from-url-gently from OSS-Fuzz

 Backport oss-fuzz tests for us to our codebase.

 Needs review.
 source: <[email-masked]>

* bf/set-head-symref (2024-10-23) 8 commits
 - fetch set_head: handle mirrored bare repositories
 - fetch: set remote/HEAD if it does not exist
 - refs: add create_only option to refs_update_symref_extended
 - refs: add TRANSACTION_CREATE_EXISTS error
 - remote set-head: better output for --auto
 - remote set-head: refactor for readability
 - refs: atomically record overwritten ref in update_symref
 - t/t5505-remote: set default branch to main

 When "git fetch $remote" notices that refs/remotes/$remote/HEAD is
 missing and discovers what branch the other side points with its
 HEAD, refs/remotes/$remote/HEAD is updated to point to it.

 Needs review.
 source: <[email-masked]>

* ps/build (2024-10-24) 21 commits
 - meson: fix conflicts with in-flight topics
 - Introduce support for the Meson build system
 - Documentation: add comparison of build systems
 - t: allow overriding build dir
 - t: better support for out-of-tree builds
 - Documentation: extract script to generate a list of mergetools
 - Documentation: teach "cmd-list.perl" about out-of-tree builds
 - Documentation: allow sourcing generated includes from separate dir
 - Makefile: simplify building of templates
 - Makefile: allow "bin-wrappers/" directory to exist
 - Makefile: refactor generators to be PWD-independent
 - Makefile: refactor GIT-VERSION-GEN to be reusable
 - Makefile: extract script to generate gitweb.cgi
 - Makefile: extract script to massage Shell scripts
 - Makefile: use "generate-perl.sh" to massage Perl library
 - Makefile: extract script to massage Perl scripts
 - Makefile: consistently use PERL_PATH
 - Makefile: consistently use @PLACEHOLDER@ to substitute
 - Makefile: use common template for GIT-BUILD-OPTIONS
 - Merge branch 'ps/platform-compat-fixes' into ps/build
 - Merge branch 'ps/upgrade-clar' into ps/build

 Build procedure update plus introduction of Mason based builds

 Under discussion.
 source: <[email-masked]>

* ej/cat-file-remote-object-info (2024-10-31) 6 commits
 - cat-file: add remote-object-info to batch-command
 - cat-file: add declaration of variable i inside its for loop
 - transport: add client support for object-info
 - serve: advertise object-info feature
 - fetch-pack: move fetch initialization
 - fetch-pack: refactor packet writing

 "git cat-file --batch" and friends can optionally ask a remote
 server about objects it does not have.

 Needs review.
 source: <[email-masked]>

* cc/promisor-remote-capability (2024-09-10) 4 commits
 - promisor-remote: check advertised name or URL
 - Add 'promisor-remote' capability to protocol v2
 - strbuf: refactor strbuf_trim_trailing_ch()
 - version: refactor strbuf_sanitize()

 The v2 protocol learned to allow the server to advertise possible
 promisor remotes, and the client to respond with what promissor
 remotes it uses, so that the server side can omit objects that the
 client can lazily obtain from these other promissor remotes.

 Comments?  I got an impression that this is premature without
 finishing the discussion on a larger picture.
 cf. <[email-masked]>
 source: <[email-masked]>

* sj/ref-contents-check (2024-10-21) 9 commits
 - ref: add symlink ref content check for files backend
 - ref: check whether the target of the symref is a ref
 - ref: add basic symref content check for files backend
 - ref: add more strict checks for regular refs
 - ref: port git-fsck(1) regular refs check for files backend
 - ref: support multiple worktrees check for refs
 - ref: initialize target name outside of check functions
 - ref: check the full refname instead of basename
 - ref: initialize "fsck_ref_report" with zero

 "git fsck" learned to issue warnings on "curiously formatted" ref
 contents that have always been taken valid but something Git
 wouldn't have written itself (e.g., missing terminating end-of-line
 after the full object name).

 Needs review.
 cf. <[email-masked]>
 source: <ZxZX5HDdq_R0C77b@ArchLinux>

* js/libgit-rust (2024-10-16) 5 commits
 - Makefile: add option to build and test libgit-rs and libgit-rs-sys
 - libgit: add higher-level libgit crate
 - libgit-sys: also export some config_set functions
 - libgit-sys: introduce Rust wrapper for libgit.a
 - common-main: split init and exit code into new files

 An rust binding to libgit.a functions has been introduced.

 Needs review.
 source: <[email-masked]>

* jt/commit-graph-missing (2024-11-05) 2 commits
  (merged to 'next' on 2024-11-06 at b4dd083c2a)
 + fetch-pack: die if in commit graph but not obj db
 + Revert "fetch-pack: add a deref_without_lazy_fetch_extended()"

 A regression where commit objects missing from a commit-graph can
 cause an infinite loop when doing a fetch in a partial clone has
 been fixed.

 Will merge to 'master'.
 source: <[email-masked]>

* kn/the-repository (2024-11-08) 9 commits
 - midx: add repository to `multi_pack_index` struct
 - config: make `packed_git_(limit|window_size)` non-global variables
 - config: make `delta_base_cache_limit` a non-global variable
 - packfile: pass down repository to `for_each_packed_object`
 - packfile: pass down repository to `has_object[_kept]_pack`
 - packfile: pass down repository to `odb_pack_name`
 - packfile: pass `repository` to static function in the file
 - packfile: use `repository` from `packed_git` directly
 - packfile: add repository to struct `packed_git`

 Various implicit uses of 'the_repoository' in the packfile code
 have been eliminated.

 Needs review.
 source: <[email-masked]>