Subject: Re: [PATCH v2 1/1] contrib/vscode/: debugging with VS Code and gdb

From: Junio C Hamano <[email-masked]>
Date: Wed, 06 Apr 2022 13:23:25 -0700

Derrick Stolee <[email-masked]> writes:

>  
>> Signed-off-by: COGONI Guillaume <[email-masked]>
>> Co-authored-by: BRESSAT Jonathan <[email-masked]>
>> Helped-by: Matthieu Moy <[email-masked]>
>> Helped-by: Derrick Stolee <[email-masked]>
>
> Here, you probably want to flip the order here (Helped-by, then
> Co-authored-by, then Signed-off-by). You probably also want the
> sign-off of your co-author, too.
>
> The sign-off should be the last thing in the message, because
> the previous lines are covered by that sign-off.

Yup.  It would record the order of events that lead to this exact
patch, which is what we want to capture.  With help by these people,
together with the co-author(s), the patch was written and author(s)
signed-off before it was sent out to the list.

> ...
> And this is the necessary fix.
>
> Thanks for working on this!

Indeed.  And thanks for a helpful review.