From: Junio C Hamano <gitster@pobox•com>
To: Jeff King <peff@peff•net>
Cc: "Tom G. Christensen" <tgc@jupiterrise•com>, git@vger•kernel.org
Subject: Re: [PATCH 7/7] Do not use curl_easy_strerror with curl < 7.12.0
Date: Wed, 12 Apr 2017 23:28:28 -0700 [thread overview]
Message-ID: <xmqqbms0q0s3.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20170406091857.hl4ndn52kj2z4ujh@sigill.intra.peff.net> (Jeff King's message of "Thu, 6 Apr 2017 05:18:57 -0400")
Jeff King <peff@peff•net> writes:
> On Wed, Apr 05, 2017 at 03:04:24PM +0200, Tom G. Christensen wrote:
> ...
> These kinds of interleaved conditionals make me nervous that we'll get
> something wrong (especially without braces, it's not immediately clear
> that both sides are a single statement).
>
> I wonder if it would be more readable to do something like:
>
> #if LIBCURL_VERSION_NUM < 0x070c00
> static const char *curl_easy_strerror(CURL *curl)
> {
> return "[error code unavailable; curl version too old]";
> }
> #endif
>
> Then callers don't have to individually deal with the ifdef. It does
> mean that the user sees that kind-of ugly message, but maybe that is a
> good thing. They know they need to upgrade curl to see more details.
Yup, thanks for a very good suggestion.
next prev parent reply other threads:[~2017-04-13 6:28 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-04 2:54 [RFC] dropping support for ancient versions of curl Jeff King
2017-04-04 3:08 ` Jeff King
2017-04-04 5:44 ` Jessie Hernandez
2017-04-04 8:17 ` Ævar Arnfjörð Bjarmason
2017-04-04 8:33 ` Jeff King
2017-04-04 10:44 ` Ævar Arnfjörð Bjarmason
2017-04-04 11:54 ` Johannes Schindelin
2017-04-04 14:06 ` Ævar Arnfjörð Bjarmason
2017-04-04 16:53 ` Brandon Williams
2017-04-04 22:46 ` Johannes Schindelin
2017-04-04 23:03 ` Brandon Williams
2017-04-04 23:03 ` Stefan Beller
2017-04-05 8:49 ` Johannes Schindelin
2017-04-05 9:29 ` Jeff King
2017-04-04 20:16 ` Jeff King
2017-04-04 13:32 ` Frank Gevaerts
2017-04-05 9:33 ` Tom G. Christensen
2017-04-05 10:51 ` Ævar Arnfjörð Bjarmason
2017-04-05 13:04 ` [PATCH 0/7] Patches to support older RHEL releases Tom G. Christensen
2017-04-05 13:04 ` [PATCH 1/7] Make NO_PERL_MAKEMAKER behave more like ExtUtils::MakeMaker Tom G. Christensen
2017-04-05 13:04 ` [PATCH 2/7] Install man pages when NO_PERL_MAKEMAKER is used Tom G. Christensen
2017-04-05 13:04 ` [PATCH 3/7] Allow svnrdump_sim.py to be used with Python 2.2 Tom G. Christensen
2017-04-05 13:40 ` Ævar Arnfjörð Bjarmason
2017-04-05 14:36 ` Tom G. Christensen
2017-04-05 13:04 ` [PATCH 4/7] Handle missing HTTP_CONNECTCODE in curl < 7.10.7 Tom G. Christensen
2017-04-05 13:50 ` Ævar Arnfjörð Bjarmason
2017-04-05 15:58 ` Franke, Knut
2017-04-05 13:04 ` [PATCH 5/7] Add support for gnupg < 1.4 Tom G. Christensen
2017-04-05 13:45 ` Ævar Arnfjörð Bjarmason
2017-04-13 6:31 ` Junio C Hamano
2017-04-13 15:17 ` Ævar Arnfjörð Bjarmason
2017-04-05 13:04 ` [PATCH 6/7] Handle missing CURLINFO_SSL_DATA_{IN,OUT} Tom G. Christensen
2017-04-05 13:52 ` Ævar Arnfjörð Bjarmason
2017-04-05 13:04 ` [PATCH 7/7] Do not use curl_easy_strerror with curl < 7.12.0 Tom G. Christensen
2017-04-05 13:53 ` Ævar Arnfjörð Bjarmason
2017-04-06 9:18 ` Jeff King
2017-04-13 6:28 ` Junio C Hamano [this message]
2017-04-13 10:52 ` Jacob Keller
2017-04-05 13:04 ` [RFC] dropping support for ancient versions of curl Tom G. Christensen
2017-04-06 0:53 ` brian m. carlson
2017-04-06 1:16 ` Todd Zullinger
2017-04-06 9:29 ` Jeff King
2017-04-07 11:18 ` Johannes Schindelin
2017-04-10 18:22 ` Jeff King
2017-04-06 9:21 ` Jeff King
2017-04-06 16:43 ` Tom G. Christensen
2017-04-07 4:54 ` Jeff King
2017-04-14 11:12 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqbms0q0s3.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=peff@peff$(echo .)net \
--cc=tgc@jupiterrise$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox