From: Junio C Hamano <gitster@pobox•com>
To: Jonathan Nieder <jrnieder@gmail•com>
Cc: Brandon Williams <bmwill@google•com>,
git@vger•kernel.org, johannes.schindelin@gmx•de
Subject: Re: [PATCH] sequencer: fix missing newline
Date: Thu, 23 Mar 2017 15:38:14 -0700 [thread overview]
Message-ID: <xmqqbmsraaax.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20170323221217.GA20794@aiede.mtv.corp.google.com> (Jonathan Nieder's message of "Thu, 23 Mar 2017 15:12:17 -0700")
Jonathan Nieder <jrnieder@gmail•com> writes:
> Brandon Williams wrote:
>
>> When using rebase --interactive where one of the lines is marked as
>> 'edit' this is the resulting output:
>>
>> Stopped at ec3b9c4... stuffYou can amend the commit now, with
> [...]
>> Signed-off-by: Brandon Williams <bmwill@google•com>
>> ---
>> sequencer.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Thanks for fixing it. I don't see any other fprintf in the file with
> missing \r or \n at the end, so this fix looks complete.
>
> Reviewed-by: Jonathan Nieder <jrnieder@gmail•com>
Thanks.
prev parent reply other threads:[~2017-03-23 22:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-23 17:02 [PATCH] sequencer: fix missing newline Brandon Williams
2017-03-23 17:40 ` Johannes Schindelin
2017-03-23 17:47 ` Brandon Williams
2017-03-23 18:22 ` Jeff King
2017-03-23 18:24 ` Jeff King
2017-03-23 18:24 ` Brandon Williams
2017-03-23 18:19 ` Junio C Hamano
2017-03-23 22:12 ` Jonathan Nieder
2017-03-23 22:38 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqbmsraaax.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=bmwill@google$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=johannes.schindelin@gmx$(echo .)de \
--cc=jrnieder@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox