From: Junio C Hamano <gitster@pobox•com>
To: "Nguyễn Thái Ngọc Duy" <pclouds@gmail•com>
Cc: git@vger•kernel.org
Subject: Re: [PATCH 15/22] remote-curl.c: mark strings for translation
Date: Mon, 29 Feb 2016 10:50:29 -0800 [thread overview]
Message-ID: <xmqqbn6zbbbe.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <1456555333-5853-16-git-send-email-pclouds@gmail.com> ("Nguyễn Thái Ngọc Duy"'s message of "Sat, 27 Feb 2016 13:42:06 +0700")
Nguyễn Thái Ngọc Duy <pclouds@gmail•com> writes:
> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail•com>
> ---
All (or at least most) of these look old ones. I'm inclined to say
we should do the whole thing post 2.8.0 release for this file.
> remote-curl.c | 40 ++++++++++++++++++++--------------------
> 1 file changed, 20 insertions(+), 20 deletions(-)
>
> diff --git a/remote-curl.c b/remote-curl.c
> index 15e48e2..d5b33aa 100644
> --- a/remote-curl.c
> +++ b/remote-curl.c
> @@ -177,7 +177,7 @@ static struct ref *parse_info_refs(struct discovery *heads)
> mid = &data[i];
> if (data[i] == '\n') {
> if (mid - start != 40)
> - die("%sinfo/refs not valid: is this a git repository?",
> + die(_("%sinfo/refs not valid: is this a git repository?"),
> url.buf);
> data[i] = 0;
> ref_name = mid + 1;
> @@ -285,13 +285,13 @@ static struct discovery *discover_refs(const char *service, int for_push)
> break;
> case HTTP_MISSING_TARGET:
> show_http_message(&type, &charset, &buffer);
> - die("repository '%s' not found", url.buf);
> + die(_("repository '%s' not found"), url.buf);
> case HTTP_NOAUTH:
> show_http_message(&type, &charset, &buffer);
> - die("Authentication failed for '%s'", url.buf);
> + die(_("Authentication failed for '%s'"), url.buf);
> default:
> show_http_message(&type, &charset, &buffer);
> - die("unable to access '%s': %s", url.buf, curl_errorstr);
> + die(_("unable to access '%s': %s"), url.buf, curl_errorstr);
> }
>
> last= xcalloc(1, sizeof(*last_discovery));
> @@ -314,7 +314,7 @@ static struct discovery *discover_refs(const char *service, int for_push)
> strbuf_reset(&exp);
> strbuf_addf(&exp, "# service=%s", service);
> if (strcmp(line, exp.buf))
> - die("invalid server response; got '%s'", line);
> + die(_("invalid server response; got '%s'"), line);
> strbuf_release(&exp);
>
> /* The header can include additional metadata lines, up
> @@ -422,7 +422,7 @@ static curlioerr rpc_ioctl(CURL *handle, int cmd, void *clientp)
> rpc->pos = 0;
> return CURLIOE_OK;
> }
> - error("unable to rewind rpc post data - try increasing http.postBuffer");
> + error(_("unable to rewind rpc post data - try increasing http.postBuffer"));
> return CURLIOE_FAILRESTART;
>
> default:
> @@ -604,11 +604,11 @@ retry:
>
> ret = git_deflate(&stream, Z_FINISH);
> if (ret != Z_STREAM_END)
> - die("cannot deflate request; zlib deflate error %d", ret);
> + die(_("cannot deflate request; zlib deflate error %d"), ret);
>
> ret = git_deflate_end_gently(&stream);
> if (ret != Z_OK)
> - die("cannot deflate request; zlib end error %d", ret);
> + die(_("cannot deflate request; zlib end error %d"), ret);
>
> gzip_size = stream.total_out;
>
> @@ -726,7 +726,7 @@ static int fetch_dumb(int nr_heads, struct ref **to_fetch)
>
> ALLOC_ARRAY(targets, nr_heads);
> if (options.depth)
> - die("dumb http transport does not support --depth");
> + die(_("dumb http transport does not support --depth"));
> for (i = 0; i < nr_heads; i++)
> targets[i] = xstrdup(oid_to_hex(&to_fetch[i]->old_oid));
>
> @@ -743,7 +743,7 @@ static int fetch_dumb(int nr_heads, struct ref **to_fetch)
> free(targets[i]);
> free(targets);
>
> - return ret ? error("fetch failed.") : 0;
> + return ret ? error(_("fetch failed.")) : 0;
> }
>
> static int fetch_git(struct discovery *heads,
> @@ -787,7 +787,7 @@ static int fetch_git(struct discovery *heads,
> for (i = 0; i < nr_heads; i++) {
> struct ref *ref = to_fetch[i];
> if (!*ref->name)
> - die("cannot fetch by sha1 over smart http");
> + die(_("cannot fetch by sha1 over smart http"));
> packet_buf_write(&preamble, "%s %s\n",
> oid_to_hex(&ref->old_oid), ref->name);
> }
> @@ -832,13 +832,13 @@ static void parse_fetch(struct strbuf *buf)
> struct object_id old_oid;
>
> if (get_oid_hex(p, &old_oid))
> - die("protocol error: expected sha/ref, got %s'", p);
> + die(_("protocol error: expected sha/ref, got %s'"), p);
> if (p[GIT_SHA1_HEXSZ] == ' ')
> name = p + GIT_SHA1_HEXSZ + 1;
> else if (!p[GIT_SHA1_HEXSZ])
> name = "";
> else
> - die("protocol error: expected sha/ref, got %s'", p);
> + die(_("protocol error: expected sha/ref, got %s'"), p);
>
> ref = alloc_ref(name);
> oidcpy(&ref->old_oid, &old_oid);
> @@ -850,7 +850,7 @@ static void parse_fetch(struct strbuf *buf)
> to_fetch[nr_heads++] = ref;
> }
> else
> - die("http transport does not support %s", buf->buf);
> + die(_("http transport does not support %s"), buf->buf);
>
> strbuf_reset(buf);
> if (strbuf_getline_lf(buf, stdin) == EOF)
> @@ -886,7 +886,7 @@ static int push_dav(int nr_spec, char **specs)
> argv_array_push(&child.args, specs[i]);
>
> if (run_command(&child))
> - die("git-http-push failed");
> + die(_("git-http-push failed"));
> return 0;
> }
>
> @@ -962,7 +962,7 @@ static void parse_push(struct strbuf *buf)
> specs[nr_spec++] = xstrdup(buf->buf + 5);
> }
> else
> - die("http transport does not support %s", buf->buf);
> + die(_("http transport does not support %s"), buf->buf);
>
> strbuf_reset(buf);
> if (strbuf_getline_lf(buf, stdin) == EOF)
> @@ -994,7 +994,7 @@ int main(int argc, const char **argv)
> git_extract_argv0_path(argv[0]);
> setup_git_directory_gently(&nongit);
> if (argc < 2) {
> - error("remote-curl: usage: git remote-curl <remote> [<url>]");
> + error(_("remote-curl: usage: git remote-curl <remote> [<url>]"));
> return 1;
> }
>
> @@ -1017,14 +1017,14 @@ int main(int argc, const char **argv)
>
> if (strbuf_getline_lf(&buf, stdin) == EOF) {
> if (ferror(stdin))
> - error("remote-curl: error reading command stream from git");
> + error(_("remote-curl: error reading command stream from git"));
> return 1;
> }
> if (buf.len == 0)
> break;
> if (starts_with(buf.buf, "fetch ")) {
> if (nongit)
> - die("remote-curl: fetch attempted without a local repo");
> + die(_("remote-curl: fetch attempted without a local repo"));
> parse_fetch(&buf);
>
> } else if (!strcmp(buf.buf, "list") || starts_with(buf.buf, "list ")) {
> @@ -1060,7 +1060,7 @@ int main(int argc, const char **argv)
> printf("\n");
> fflush(stdout);
> } else {
> - error("remote-curl: unknown command '%s' from git", buf.buf);
> + error(_("remote-curl: unknown command '%s' from git"), buf.buf);
> return 1;
> }
> strbuf_reset(&buf);
next prev parent reply other threads:[~2016-02-29 18:50 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-27 6:41 [PATCH 00/22] Mark more strings for translation Nguyễn Thái Ngọc Duy
2016-02-27 6:41 ` [PATCH 01/22] credential-cache--daemon: enable localized messages Nguyễn Thái Ngọc Duy
2016-02-27 6:41 ` [PATCH 02/22] builtin/blame.c: mark strings for translation Nguyễn Thái Ngọc Duy
2016-02-28 18:57 ` Junio C Hamano
2016-02-29 0:33 ` Duy Nguyen
2016-02-29 18:22 ` Junio C Hamano
2016-02-27 6:41 ` [PATCH 03/22] builtin/checkout.c: " Nguyễn Thái Ngọc Duy
2016-02-28 19:00 ` Junio C Hamano
2016-02-27 6:41 ` [PATCH 04/22] builtin/clone.c: " Nguyễn Thái Ngọc Duy
2016-02-28 19:05 ` Junio C Hamano
2016-02-27 6:41 ` [PATCH 05/22] builtin/config.c: " Nguyễn Thái Ngọc Duy
2016-02-29 18:25 ` Junio C Hamano
2016-02-27 6:41 ` [PATCH 06/22] " Nguyễn Thái Ngọc Duy
2016-02-27 6:41 ` [PATCH 07/22] builtin/update-index.c: " Nguyễn Thái Ngọc Duy
2016-02-29 18:27 ` Junio C Hamano
2016-02-27 6:41 ` [PATCH 08/22] convert.c: " Nguyễn Thái Ngọc Duy
2016-02-29 18:29 ` Junio C Hamano
2016-02-27 6:42 ` [PATCH 09/22] credential-cache--daemon.c: " Nguyễn Thái Ngọc Duy
2016-02-29 18:30 ` Junio C Hamano
2016-02-27 6:42 ` [PATCH 10/22] http.c: " Nguyễn Thái Ngọc Duy
2016-02-29 18:31 ` Junio C Hamano
2016-02-27 6:42 ` [PATCH 11/22] ident.c: " Nguyễn Thái Ngọc Duy
2016-02-29 18:34 ` Junio C Hamano
2016-03-01 14:56 ` Jeff King
2016-02-27 6:42 ` [PATCH 12/22] notes.c: " Nguyễn Thái Ngọc Duy
2016-02-29 18:36 ` Junio C Hamano
2016-02-27 6:42 ` [PATCH 13/22] ref-filter.c: " Nguyễn Thái Ngọc Duy
2016-02-29 18:41 ` Junio C Hamano
2016-02-27 6:42 ` [PATCH 14/22] refs/files-backend.c: " Nguyễn Thái Ngọc Duy
2016-02-29 18:43 ` Junio C Hamano
2016-03-01 10:40 ` Duy Nguyen
2016-02-27 6:42 ` [PATCH 15/22] remote-curl.c: " Nguyễn Thái Ngọc Duy
2016-02-29 18:50 ` Junio C Hamano [this message]
2016-02-27 6:42 ` [PATCH 16/22] run-command.c: " Nguyễn Thái Ngọc Duy
2016-02-29 18:52 ` Junio C Hamano
2016-03-01 0:00 ` Stefan Beller
2016-02-27 6:42 ` [PATCH 17/22] sha1_file.c: " Nguyễn Thái Ngọc Duy
2016-02-27 6:42 ` [PATCH 18/22] submodule.c: " Nguyễn Thái Ngọc Duy
2016-02-27 6:42 ` [PATCH 19/22] trailer.c: " Nguyễn Thái Ngọc Duy
2016-02-29 18:55 ` Junio C Hamano
2016-02-27 6:42 ` [PATCH 20/22] transport-helper.c: mark strings for translating Nguyễn Thái Ngọc Duy
2016-02-27 6:42 ` [PATCH 21/22] transport.c: " Nguyễn Thái Ngọc Duy
2016-02-27 6:42 ` [PATCH 22/22] wrapper.c: mark strings for translation Nguyễn Thái Ngọc Duy
2016-02-27 17:34 ` [PATCH 00/22] Mark more " Junio C Hamano
2016-02-27 19:00 ` Junio C Hamano
2016-02-28 0:43 ` Duy Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqbn6zbbbe.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=pclouds@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox