From: Junio C Hamano <gitster@pobox•com>
To: Jeff King <peff@peff•net>
Cc: Stefan Beller <sbeller@google•com>,
git@vger•kernel.org, sunshine@sunshineco•com
Subject: Re: [PATCH] checkout-index.c: Unconditionally free memory
Date: Sat, 02 May 2015 20:03:07 -0700 [thread overview]
Message-ID: <xmqqbni2wefo.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20150503023024.GA4269@peff.net> (Jeff King's message of "Sat, 2 May 2015 22:30:24 -0400")
Jeff King <peff@peff•net> writes:
>> Sure, the prefix could even be "prefix_path(): $message", I would
>> think.
>
> I almost suggested that, but it not a change to prefix_path at all, but
> rather to its callers. That may be getting nit-picky, though. :)
Using "prefix_path(): free returned memory in the callers" as the
title, with the body that explains that an earlier fix to make that
a requirement but forgot to do so for a few that are fixed in this
commit, would be sensible, no? It is not about how prefix_path() is
implemented but its returned value, which is still about that
function.
next prev parent reply other threads:[~2015-05-03 3:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-01 19:28 [PATCH] checkout-index.c: Unconditionally free memory Stefan Beller
2015-05-01 19:33 ` Eric Sunshine
2015-05-01 19:41 ` Eric Sunshine
2015-05-01 19:50 ` Jeff King
2015-05-01 22:33 ` Stefan Beller
2015-05-01 22:39 ` Jeff King
2015-05-01 22:35 ` Stefan Beller
2015-05-01 22:43 ` Jeff King
2015-05-03 2:15 ` Junio C Hamano
2015-05-03 2:30 ` Jeff King
2015-05-03 3:03 ` Junio C Hamano [this message]
2015-05-01 23:41 ` Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqbni2wefo.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=peff@peff$(echo .)net \
--cc=sbeller@google$(echo .)com \
--cc=sunshine@sunshineco$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox