public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox•com>
To: Karsten Blees <karsten.blees@gmail•com>
Cc: Git List <git@vger•kernel.org>, msysGit <msysgit@googlegroups•com>
Subject: Re: [PATCH 0/3] Win32: nanosecond-precision file times
Date: Thu, 12 Feb 2015 11:48:26 -0800	[thread overview]
Message-ID: <xmqqbnkysygl.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <54DBEAA5.6000205@gmail.com> (Karsten Blees's message of "Thu, 12 Feb 2015 00:49:57 +0100")

Karsten Blees <karsten.blees@gmail•com> writes:

> This patch series was inspired by the problem that Git does not
> detect changed file content if st_size, st_mtime and st_ctime
> are unchanged. This was apparently caused by VSS2Git resetting
> mtime to a value in the past. [1]
>
> I believe (or rather hope) that all involved in the discussion
> agree that Git cannot reasonably be expected to detect changed
> file content if file time(s) are reset on purpose.
>
> However, some users have expressed concerns that 'same size and
> mtime' [2] may theoretically happen by chance in daily operation.

Hmph.

Haven't we already accepted that it is not just "may theoretically
happen" and had counter-measures in racy-git detection machinery
for quite some time?

  parent reply	other threads:[~2015-02-12 19:48 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-11 23:49 [PATCH 0/3] Win32: nanosecond-precision file times Karsten Blees
2015-02-11 23:51 ` [PATCH 1/3] Win32: make FILETIME conversion functions public Karsten Blees
2015-02-11 23:52 ` [PATCH 2/3] Win32: replace MSVCRT's fstat() with a Win32-based implementation Karsten Blees
2015-02-11 23:53 ` [PATCH 3/3] Win32: implement nanosecond-precision file times Karsten Blees
2015-02-12 23:15   ` Thomas Braun
2015-02-12 23:44     ` Karsten Blees
2015-02-12 19:48 ` Junio C Hamano [this message]
2015-02-12 22:30   ` Re: [PATCH 0/3] Win32: " Johannes Schindelin
2015-02-12 22:57   ` Karsten Blees
2015-02-12 23:38     ` Junio C Hamano
2015-02-13  1:59       ` Karsten Blees
2015-02-13 19:28         ` Junio C Hamano
2015-02-16 20:18           ` Karsten Blees
2015-02-16 22:10             ` Junio C Hamano
2015-02-17 21:57               ` Karsten Blees

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqbnkysygl.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=karsten.blees@gmail$(echo .)com \
    --cc=msysgit@googlegroups$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox