public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox•com>
To: "brian m. carlson" <sandals@crustytoothpaste•net>
Cc: git@vger•kernel.org, Derek Moore <derek.p.moore@gmail•com>
Subject: Re: [PATCH] Documentation: fix misrender of pretty-formats in Asciidoctor
Date: Wed, 08 Oct 2014 13:53:42 -0700	[thread overview]
Message-ID: <xmqqbnpm8eqx.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1412801170-60741-1-git-send-email-sandals@crustytoothpaste.net> (brian m. carlson's message of "Wed, 8 Oct 2014 20:46:10 +0000")

"brian m. carlson" <sandals@crustytoothpaste•net> writes:

> Neither the AsciiDoc nor the Asciidoctor documentation specify whether
> the same number of delimiter characters must be used to end a block as
> to begin it, although both sets of documentation show exactly matching
> pairs.  AsciiDoc allows mismatches, but AsciiDoctor apparently does not.
> Adjust the pretty formats documentation to use matching pairs to prevent
> a misrendering where the remainder of the document was rendered as a
> listing block.
>
> Signed-off-by: brian m. carlson <sandals@crustytoothpaste•net>
> ---

Thanks, well spotted, well described and well done ;-)

Will queue.

>  Documentation/pretty-formats.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/pretty-formats.txt b/Documentation/pretty-formats.txt
> index eecc39d..dcf7429 100644
> --- a/Documentation/pretty-formats.txt
> +++ b/Documentation/pretty-formats.txt
> @@ -95,7 +95,7 @@ would show something like this:
>  The author of fe6e0ee was Junio C Hamano, 23 hours ago
>  The title was >>t4119: test autocomputing -p<n> for traditional diff input.<<
>  
> ---------
> +-------
>  +
>  The placeholders are:

  reply	other threads:[~2014-10-08 20:54 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-08 17:49 git-log man2html conversion broken: http://git-scm.com/docs/git-log Derek Moore
2014-10-08 20:46 ` [PATCH] Documentation: fix misrender of pretty-formats in Asciidoctor brian m. carlson
2014-10-08 20:53   ` Junio C Hamano [this message]
2014-10-09  2:31   ` Jeff King
2014-10-09  2:58     ` brian m. carlson
2014-10-09  2:29 ` git-log man2html conversion broken: http://git-scm.com/docs/git-log Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqbnpm8eqx.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=derek.p.moore@gmail$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=sandals@crustytoothpaste$(echo .)net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox