From: Junio C Hamano <gitster@pobox•com>
To: Jacob Keller <jacob.e.keller@intel•com>
Cc: git@vger•kernel.org
Subject: Re: [PATCH v8 0/4] tag: configure default tag sort via .gitconfig
Date: Tue, 15 Jul 2014 15:40:48 -0700 [thread overview]
Message-ID: <xmqqbnsqtfdb.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1405459754-4220-1-git-send-email-jacob.e.keller@intel.com> (Jacob Keller's message of "Tue, 15 Jul 2014 14:29:10 -0700")
Jacob Keller <jacob.e.keller@intel•com> writes:
> This patch series is hopefully the final version of a series of patches which
> updates git-tag to allow the .gitconfig variable 'tag.sort' to be used as the
> default sort parameter. This version uses a new set/pop error routine setup
> which enables correctly modifying the error routine to handle the config vs the
> command line.
>
> In addition, I split the patch such that all the changes to the original
> parse_opt_sort are shown, and the following patch which extracts this function
> is just a function extraction with no changes, making it easier to review the
> new changes. One other minor bug fix is included as well.
>
> Jacob Keller (4):
> usage: make error functions a stack
> tag: fix --sort tests to use cat<<-\EOF format
> tag: update parsing to be more precise regarding errors
> tag: support configuring --sort via .gitconfig
The first one looked somewhat tricky, but looked nice overall from a
cursory reading.
Thanks.
prev parent reply other threads:[~2014-07-15 22:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-15 21:29 [PATCH v8 0/4] tag: configure default tag sort via .gitconfig Jacob Keller
2014-07-15 21:29 ` [PATCH v8 1/4] usage: make error functions a stack Jacob Keller
2014-07-15 22:47 ` Junio C Hamano
2014-07-15 23:24 ` Keller, Jacob E
2014-07-15 23:26 ` Keller, Jacob E
2014-07-16 0:49 ` Junio C Hamano
2014-07-16 19:50 ` Keller, Jacob E
2014-07-15 21:29 ` [PATCH v8 2/4] tag: fix --sort tests to use cat<<-\EOF format Jacob Keller
2014-07-15 21:29 ` [PATCH v8 3/4] tag: update parsing to be more precise regarding errors Jacob Keller
2014-07-15 21:29 ` [PATCH v8 4/4] tag: support configuring --sort via .gitconfig Jacob Keller
2014-07-15 22:40 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqbnsqtfdb.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=jacob.e.keller@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox