public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox•com>
To: Felipe Contreras <felipe.contreras@gmail•com>
Cc: git@vger•kernel.org
Subject: Re: [PATCH 0/2] remote-helpers: graduate
Date: Mon, 21 Apr 2014 11:06:39 -0700	[thread overview]
Message-ID: <xmqqbnvua768.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1398029971-1396-1-git-send-email-felipe.contreras@gmail.com> (Felipe Contreras's message of "Sun, 20 Apr 2014 16:39:29 -0500")

Felipe Contreras <felipe.contreras@gmail•com> writes:

> There doesn't seem to be any reason to keep these remote-helpers in the contrib
> area.

Yay.

I wouldn't phrase it "doesn't seem to be any reason", though.  The
decision to include is not done due to lack of negatives, but
because adding them would be useful.

And I think for these two, it holds true---people seem to have been
experimenting with them and getting good results with occasional bug
reports that are addressed in a reasonable promptness.

Will queue.


> Felipe Contreras (2):
>   remote-helpers: move out of contrib
>   remote-helpers: move tests out of contrib
>
>  .gitignore                                                 |  2 ++
>  Makefile                                                   |  2 ++
>  contrib/remote-helpers/Makefile                            | 14 --------------
>  contrib/remote-helpers/git-remote-bzr => git-remote-bzr.py |  0
>  contrib/remote-helpers/git-remote-hg => git-remote-hg.py   |  0
>  t/Makefile                                                 |  8 +++++++-
>  .../remote-helpers/test-bzr.sh => t/remote-helpers/bzr.t   |  4 ++--
>  .../test-hg-bidi.sh => t/remote-helpers/hg-bidi.t          |  4 ++--
>  .../test-hg-hg-git.sh => t/remote-helpers/hg-hg-git.t      |  6 +++---
>  contrib/remote-helpers/test-hg.sh => t/remote-helpers/hg.t |  4 ++--
>  10 files changed, 20 insertions(+), 24 deletions(-)
>  delete mode 100644 contrib/remote-helpers/Makefile
>  rename contrib/remote-helpers/git-remote-bzr => git-remote-bzr.py (100%)
>  rename contrib/remote-helpers/git-remote-hg => git-remote-hg.py (100%)
>  rename contrib/remote-helpers/test-bzr.sh => t/remote-helpers/bzr.t (98%)
>  rename contrib/remote-helpers/test-hg-bidi.sh => t/remote-helpers/hg-bidi.t (97%)
>  rename contrib/remote-helpers/test-hg-hg-git.sh => t/remote-helpers/hg-hg-git.t (98%)
>  rename contrib/remote-helpers/test-hg.sh => t/remote-helpers/hg.t (99%)

      parent reply	other threads:[~2014-04-21 18:06 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-20 21:39 [PATCH 0/2] remote-helpers: graduate Felipe Contreras
2014-04-20 21:39 ` [PATCH 1/2] remote-helpers: move out of contrib Felipe Contreras
2014-04-20 21:39 ` [PATCH 2/2] remote-helpers: move tests " Felipe Contreras
2014-04-21 18:36   ` Junio C Hamano
2014-04-21 18:53     ` Felipe Contreras
2014-04-21 19:24       ` Junio C Hamano
2014-04-21 19:23         ` Felipe Contreras
2014-04-21 18:06 ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqbnvua768.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=felipe.contreras@gmail$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox