From: Junio C Hamano <gitster@pobox•com>
To: Jeff King <peff@peff•net>
Cc: Matt Burke <spraints@gmail•com>, git@vger•kernel.org
Subject: Re: Bug report: stash in upstream caused remote fetch to fail
Date: Mon, 06 Jan 2014 08:16:31 -0800 [thread overview]
Message-ID: <xmqqbnzpkrvk.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20140106152742.GA26221@sigill.intra.peff.net> (Jeff King's message of "Mon, 6 Jan 2014 10:27:42 -0500")
Jeff King <peff@peff•net> writes:
> On Fri, Jan 03, 2014 at 04:12:51PM -0500, Matt Burke wrote:
>
>> + git init -q
>> + git fetch -q -fu ../../../other '+refs/*:refs/*'
>> fatal: bad object 9b985fbe6a2b783c16756077a8be261c94b6c197
>> error: ../../../other did not send all necessary objects
>
> I was going to ask you to send your repository, but I can easily
> reproduce here. I guess people don't run into it because it's uncommon
> to fetch the whole refs/ namespace from a non-bare repo (and bare repos
> do not tend to have stashes). Here's a minimal reproduction recipe:
>
> git init repo &&
> cd repo &&
> echo content >foo &&
> git add . &&
> git commit -m foo &&
> echo more >>foo &&
> git stash &&
> git init --bare sub &&
> cd sub &&
> git fetch .. 'refs/*:refs/*'
>
> It looks like we are not feeding refs/stash properly to pack-objects.
> I'll try to take a closer look later today.
I looked at this in the past and I vaguely recall that we reject it
in the for-each-ref loop with check-ref-format saying "eh, that is a
single-level name".
At that point I stopped digging, thinking it was a feature ;-)
based on your exact observation about stash vs bare/non-bare.
next prev parent reply other threads:[~2014-01-06 16:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-03 21:12 Bug report: stash in upstream caused remote fetch to fail Matt Burke
2014-01-06 15:27 ` Jeff King
2014-01-06 16:16 ` Junio C Hamano [this message]
2014-01-06 19:36 ` Jeff King
2014-01-06 20:17 ` Junio C Hamano
2014-01-06 23:03 ` Jeff King
2014-01-06 23:22 ` Junio C Hamano
2014-01-07 3:19 ` Junio C Hamano
2014-01-15 10:46 ` Jeff King
2014-01-15 10:48 ` Jeff King
-- strict thread matches above, loose matches on Subject: below --
2012-02-01 16:59 Andrew Walrond
[not found] ` <874nvap9hj.fsf@thomas.inf.ethz.ch>
2012-02-01 22:37 ` Andrew Walrond
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqbnzpkrvk.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=peff@peff$(echo .)net \
--cc=spraints@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox