Subject: Re: [PATCH] rev-parse: have --parseopt callers exit 0 on --help

From: Junio C Hamano <[email-masked]>
Date: Mon, 16 Mar 2026 17:47:19 -0700

"brian m. carlson" <[email-masked]> writes:

> Signed-off-by: brian m. carlson <[email-masked]>
> ---
>  parse-options.c               | 2 +-
>  t/t1502-rev-parse-parseopt.sh | 9 +++++++--
>  t/t1502/optionspec-neg.help   | 1 +
>  t/t1502/optionspec.help       | 1 +
>  4 files changed, 10 insertions(+), 3 deletions(-)

Has t1517 passed for you?

Queued directly on top of v2.53.0, I am seeing:

expecting success of 1517.169 ''git instaweb -h' outside a repository':
                test_expect_code 129 nongit git $cmd -h >usage &&
                test_grep "[Uu]sage: git $cmd " usage

test_expect_code: command exited with 0, we wanted 129 nongit git instaweb -h
not ok 169 - 'git instaweb -h' outside a repository
<<<<<