From: Junio C Hamano <gitster@pobox•com>
To: Usman Akinyemi <usmanakinyemi202@gmail•com>
Cc: git@vger•kernel.org, christian.couder@gmail•com,
me@ttaylorr•com, phillip.wood123@gmail•com, ps@pks•im
Subject: Re: [RFC PATCH 1/2] remote: move remote group resolution to remote.c
Date: Fri, 06 Mar 2026 10:12:14 -0800 [thread overview]
Message-ID: <xmqqcy1g25fl.fsf@gitster.g> (raw)
In-Reply-To: <20260305223248.170785-2-usmanakinyemi202@gmail.com> (Usman Akinyemi's message of "Fri, 6 Mar 2026 04:02:47 +0530")
Usman Akinyemi <usmanakinyemi202@gmail•com> writes:
> diff --git a/remote.h b/remote.h
> index fc052945ee..fa38f951a2 100644
> --- a/remote.h
> +++ b/remote.h
> @@ -347,6 +347,18 @@ int branch_has_merge_config(struct branch *branch);
>
> int branch_merge_matches(struct branch *, int n, const char *);
>
> +/* list of the remote in a group as configured */
> +struct remote_group_data {
> + const char *name;
> + struct string_list *list;
> +};
> +
> +int get_remote_group(const char *key, const char *value,
> + const struct config_context *ctx UNUSED,
> + void *priv);
It is dubious to carry UNUESD over to an external declaration in a
public header file, unless it is a "static inline" definition that
comes with the implementation.
Other than that, move looks correct and it is generally a good idea.
When moving functions and types that have been private to the
implementation of a subsystem to public namespace, we need to be
careful to consider if the names of these things are specific
enough. With "remote_group" in them, they are all good as-is in
this case, and can go public without giving them "better" names.
Thanks.
next prev parent reply other threads:[~2026-03-06 18:12 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-05 22:32 [RFC PATCH 0/2] push: add support for pushing to remote groups Usman Akinyemi
2026-03-05 22:32 ` [RFC PATCH 1/2] remote: move remote group resolution to remote.c Usman Akinyemi
2026-03-06 18:12 ` Junio C Hamano [this message]
2026-03-09 0:43 ` Usman Akinyemi
2026-03-05 22:32 ` [RFC PATCH 2/2] push: support pushing to a remote group Usman Akinyemi
2026-03-07 2:12 ` Junio C Hamano
2026-03-09 0:56 ` Usman Akinyemi
2026-03-09 13:38 ` Junio C Hamano
2026-03-18 20:40 ` [RFC PATCH v2 0/2] push: add support for pushing to remote groups Usman Akinyemi
2026-03-18 20:40 ` [RFC PATCH v2 1/2] remote: move remote group resolution to remote.c Usman Akinyemi
2026-03-18 20:40 ` [RFC PATCH v2 2/2] push: support pushing to a remote group Usman Akinyemi
2026-03-18 20:57 ` Junio C Hamano
2026-03-18 21:58 ` Junio C Hamano
2026-03-18 22:25 ` Junio C Hamano
2026-03-19 17:02 ` Junio C Hamano
2026-03-25 18:42 ` Usman Akinyemi
2026-03-18 21:57 ` [RFC PATCH v2 0/2] push: add support for pushing to remote groups Junio C Hamano
2026-03-18 23:13 ` Usman Akinyemi
2026-03-25 19:09 ` [RFC PATCH v3 " Usman Akinyemi
2026-03-25 19:09 ` [RFC PATCH v3 1/2] remote: move remote group resolution to remote.c Usman Akinyemi
2026-03-25 19:09 ` [RFC PATCH v3 2/2] push: support pushing to a remote group Usman Akinyemi
2026-03-25 19:47 ` Junio C Hamano
2026-03-31 22:35 ` Usman Akinyemi
2026-03-31 23:45 ` Usman Akinyemi
2026-04-01 16:56 ` Junio C Hamano
2026-03-27 22:18 ` Junio C Hamano
2026-04-27 14:05 ` [RFC PATCH v3 0/2] push: add support for pushing to remote groups Usman Akinyemi
2026-04-27 14:05 ` [RFC PATCH v4 1/2] remote: move remote group resolution to remote.c Usman Akinyemi
2026-04-27 14:05 ` [RFC PATCH v4 2/2] push: support pushing to a remote group Usman Akinyemi
2026-04-28 1:47 ` [RFC PATCH v3 0/2] push: add support for pushing to remote groups Junio C Hamano
2026-05-03 15:33 ` [RFC PATCH v5 0/3] " Usman Akinyemi
2026-05-03 15:34 ` [RFC PATCH v5 1/3] remote: fix sign-compare warnings in push_cas_option Usman Akinyemi
2026-05-03 15:34 ` [RFC PATCH v5 2/3] remote: move remote group resolution to remote.c Usman Akinyemi
2026-05-03 15:34 ` [RFC PATCH v5 3/3] push: support pushing to a remote group Usman Akinyemi
2026-05-12 15:05 ` Kristoffer Haugsbakk
2026-05-18 18:27 ` [RFC PATCH v5 0/3] push: add support for pushing to remote groups Usman Akinyemi
2026-05-18 18:27 ` [PATCH v6 1/3] remote: fix sign-compare warnings in push_cas_option Usman Akinyemi
2026-05-18 18:27 ` [PATCH v6 2/3] remote: move remote group resolution to remote.c Usman Akinyemi
2026-05-18 18:27 ` [PATCH v6 3/3] push: support pushing to a remote group Usman Akinyemi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqcy1g25fl.fsf@gitster.g \
--to=gitster@pobox$(echo .)com \
--cc=christian.couder@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=me@ttaylorr$(echo .)com \
--cc=phillip.wood123@gmail$(echo .)com \
--cc=ps@pks$(echo .)im \
--cc=usmanakinyemi202@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox