Subject: Re: [PATCH v3 2/8] meson: stop printing 'https' option twice in our summaries

From: Junio C Hamano <[email-masked]>
Date: Wed, 09 Jul 2025 08:17:23 -0700

Patrick Steinhardt <[email-masked]> writes:

> The value for the 'https' backend option is printed twice: once via the
> summary of auto-detected features and once via our summary of backends.
> Drop it from the former summary.
>
> Signed-off-by: Patrick Steinhardt <[email-masked]>
> ---
>  meson.build | 1 -
>  1 file changed, 1 deletion(-)

Good eyes.  To me the distinction between "Auto-detected features"
and "Backends" feel a bit blurry, but most of the things in the
former are what dependency() returned, while https_backend is very
much driven by custom code of ours, so removing from "Auto-detected"
does make senseto me.

Thanks.

> diff --git a/meson.build b/meson.build
> index 4ee1a55b0bb..0ed00254ef3 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -2200,7 +2200,6 @@ summary({
>    'expat': expat.found(),
>    'gettext': intl.found(),
>    'gitweb': gitweb_option.allowed(),
> -  'https': https_backend,
>    'iconv': iconv.found(),
>    'pcre2': pcre2.found(),
>    'perl': perl_features_enabled,