Subject: Re: [GSoC PATCH v2] revision: remove log_reencode field from rev_info

From: Junio C Hamano <[email-masked]>
Date: Tue, 22 Apr 2025 15:25:45 -0700

Lucas Seiki Oshiro <[email-masked]> writes:

> Remove the log_reencode field from struct rev-info, as it is not used.
> This field was introduced in 52883fb, but it hasn't been used since its
> introduction.

"52883fbd (Teach log family --encoding, 2006-12-25)" is how you
would refer to existing commit in the history.  I'll tweak that part
of the proposed log message before applying so there is no need to
resend.

Thanks.

>
> Helped-by: Patrick Steinhardt <[email-masked]>
> Signed-off-by: Lucas Seiki Oshiro <[email-masked]>
> ---
> Hi!
>
> Since this patch wasn't merged, I'm sending a v2 only applying the nitpick from
> the previous review in the commit message :-)
>
> Thanks!
>
>  revision.h | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/revision.h b/revision.h
> index 71e984c452..87f8d798c2 100644
> --- a/revision.h
> +++ b/revision.h
> @@ -292,7 +292,6 @@ struct rev_info {
>  	struct string_list *ref_message_ids;
>  	int		add_signoff;
>  	const char	*extra_headers;
> -	const char	*log_reencode;
>  	const char	*subject_prefix;
>  	int		patch_name_max;
>  	int		no_inline;