From: Junio C Hamano <gitster@pobox•com>
To: Eric Sunshine <sunshine@sunshineco•com>
Cc: Mahendra Dani <danimahendra0904@gmail•com>,
Patrick Steinhardt <ps@pks•im>,
git@vger•kernel.org
Subject: Re: [PATCH 1/1] t1403: prefer test_path_exists helper function
Date: Tue, 04 Mar 2025 09:49:00 -0800 [thread overview]
Message-ID: <xmqqcyewr8j7.fsf@gitster.g> (raw)
In-Reply-To: <CAPig+cQ275qBWzaYmMXydiA_8+CTx3FhAAY+o8ro+hD03wzu0g@mail.gmail.com> (Eric Sunshine's message of "Tue, 4 Mar 2025 12:35:43 -0500")
Eric Sunshine <sunshine@sunshineco•com> writes:
> On Tue, Mar 4, 2025 at 7:05 AM Junio C Hamano <gitster@pobox•com> wrote:
>> Mahendra Dani <danimahendra0904@gmail•com> writes:
>> >> > remove_object() {
>> >> > file=$(sha1_file "$*") &&
>> >> > - test -e "$file" &&
>> >> > + test_path_exists "$file" &&
>> >> > rm -f "$file"
>> >> > } &&
> That's a good question to ask, but isn't the implied suggestion of
> dropping "-f" going in the wrong direction? If I'm reading
> remove_object() correctly, `test -e` is being used as control flow,
> *not* as an assertion that the file exists.
If sha1_file says the loose object must be at path $file, and the
call to test -e "$file" returns false, two things happen in this
function:
(1) control stops and "rm -f" does not trigger
(2) the function returns non-zero status to the caller
If you omit the check and say rm "$file" instead, under the same
scenario, (1) "rm" is attempted, but there is nothing to remove so
the command returns non-zero status, and (2) the function returns
that non-zero status to the caller
If the file does exist, both will remove the file, and give the
caller zero status return.
So?
next prev parent reply other threads:[~2025-03-04 17:49 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-01 10:58 [GSOC][PATCH 0/1] t1403: prefer test_path_exists helper function Mahendra Dani
2025-03-01 10:58 ` [PATCH 1/1] " Mahendra Dani
2025-03-03 10:26 ` Patrick Steinhardt
2025-03-04 2:27 ` Mahendra Dani
2025-03-04 12:05 ` Junio C Hamano
2025-03-04 17:24 ` Mahendra Dani
2025-03-04 17:26 ` Junio C Hamano
2025-03-04 17:35 ` Mahendra Dani
2025-03-04 17:44 ` Junio C Hamano
2025-03-04 17:49 ` Mahendra Dani
2025-03-04 18:07 ` Junio C Hamano
2025-03-04 17:35 ` Eric Sunshine
2025-03-04 17:49 ` Junio C Hamano [this message]
2025-03-04 18:07 ` Eric Sunshine
2025-03-04 18:28 ` Eric Sunshine
2025-03-04 18:30 ` Junio C Hamano
2025-03-04 9:15 ` [GSOC][PATCH v2 0/1] t1403: verify path exists and is a file Mahendra Dani
2025-03-04 9:41 ` [GSOC][PATCH v3 " Mahendra Dani
2025-03-04 9:41 ` [PATCH v3 1/1] t1403: verify that " Mahendra Dani
2025-03-04 18:05 ` Junio C Hamano
2025-03-04 18:06 ` Junio C Hamano
2025-03-04 18:13 ` Mahendra Dani
2025-03-04 11:23 ` [PATCH v4 0/1] t1403: verify " Mahendra Dani
2025-03-04 11:27 ` Mahendra Dani
2025-03-04 11:27 ` [PATCH v4 1/1] t1403: verify that " Mahendra Dani
2025-03-04 18:13 ` Junio C Hamano
2025-03-04 18:19 ` Mahendra Dani
2025-03-04 16:00 ` [GSOC][PATCH v3 0/1] t1403: verify " Junio C Hamano
2025-03-04 9:27 ` [PATCH v2 1/1] t1403: verify that " Mahendra Dani
2025-03-04 11:02 ` Patrick Steinhardt
2025-03-04 11:15 ` Mahendra Dani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqcyewr8j7.fsf@gitster.g \
--to=gitster@pobox$(echo .)com \
--cc=danimahendra0904@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=ps@pks$(echo .)im \
--cc=sunshine@sunshineco$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox