Subject: Re: [PATCH] pretty: avoid double negative in format_commit_item()

From: Junio C Hamano <[email-masked]>
Date: Fri, 07 Jul 2023 12:06:37 -0700

René Scharfe <[email-masked]> writes:

> Test for equality with no_flush, which has enough negation already.  Get
> rid of the unnecessary parentheses while at it.

Makes sense.  This double negation was with us since a5752342
(pretty: support padding placeholders, %< %> and %><, 2013-04-19),
that is more than 10 years old ;-)

Will queue.

Thanks.

> Signed-off-by: René Scharfe <[email-masked]>
> ---
>  pretty.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/pretty.c b/pretty.c
> index 7862be105d..81cdc9f2cd 100644
> --- a/pretty.c
> +++ b/pretty.c
> @@ -1855,10 +1855,10 @@ static size_t format_commit_item(struct strbuf *sb, /* in UTF-8 */
>  	}
>
>  	orig_len = sb->len;
> -	if ((context)->flush_type != no_flush)
> -		consumed = format_and_pad_commit(sb, placeholder, context);
> -	else
> +	if (context->flush_type == no_flush)
>  		consumed = format_commit_one(sb, placeholder, context);
> +	else
> +		consumed = format_and_pad_commit(sb, placeholder, context);
>  	if (magic == NO_MAGIC)
>  		return consumed;
>
> --
> 2.41.0