From: Junio C Hamano <gitster@pobox•com>
To: Karthik Nayak <karthik.188@gmail•com>
Cc: git@vger•kernel.org, toon@iotcl•com
Subject: Re: [PATCH v3 2/2] attr: add flag `-r|--revisions` to work with revisions
Date: Sat, 17 Dec 2022 09:33:03 +0900 [thread overview]
Message-ID: <xmqqcz8ikgxs.fsf@gitster.g> (raw)
In-Reply-To: <20221216093552.3171319-3-karthik.188@gmail.com> (Karthik Nayak's message of "Fri, 16 Dec 2022 10:35:52 +0100")
> diff --git a/attr.c b/attr.c
> index 42ad6de8c7..99883024ec 100644
> --- a/attr.c
> +++ b/attr.c
> @@ -11,8 +11,13 @@
> #include "exec-cmd.h"
> #include "attr.h"
> #include "dir.h"
> +#include "git-compat-util.h"
Unneeded. cf. Documentation/CodingGuidelines
- The first #include in C files, except in platform specific compat/
implementations, must be either "git-compat-util.h", "cache.h" or
"builtin.h". You do not have to include more than one of these.
and this file already begins with including "cache.h".
By the way,
$ make
$ cd t
$ sh t0003-attributes.sh -i -x
Initialized empty Git repository in /home/gitster/w/git.git/t/trash directory.t0003-attributes/.git/
expecting success of 0003.1 'open-quoted pathname':
echo "\"a test=a" >.gitattributes &&
attr_check a unspecified
++ echo '"a test=a'
++ attr_check a unspecified
++ attr_check_basic a unspecified
++ path=a
++ expect=unspecified
++ git_opts=
++ git check-attr test -- a
t0003-attributes.sh: line 9: 1508946 Segmentation fault git $git_opts check-attr test -- "$path" > actual 2> err
error: last command exited with $?=139
not ok 1 - open-quoted pathname
#
# echo "\"a test=a" >.gitattributes &&
# attr_check a unspecified
#
1..1
$ exit
there seems to be something fishy in this patch.
next prev parent reply other threads:[~2022-12-17 0:33 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-16 9:35 [PATCH v3 0/2] check-attr: add support to work with revisions Karthik Nayak
2022-12-16 9:35 ` [PATCH v3 1/2] t0003: move setup for `--all` into new block Karthik Nayak
2022-12-16 9:35 ` [PATCH v3 2/2] attr: add flag `-r|--revisions` to work with revisions Karthik Nayak
2022-12-16 23:45 ` Junio C Hamano
2022-12-17 15:23 ` Karthik Nayak
2022-12-21 6:10 ` Toon Claes
2022-12-17 0:33 ` Junio C Hamano [this message]
2022-12-17 15:27 ` Karthik Nayak
2022-12-16 16:17 ` [PATCH v3 0/2] check-attr: add support " Ævar Arnfjörð Bjarmason
2022-12-16 22:38 ` Junio C Hamano
2022-12-19 8:45 ` Ævar Arnfjörð Bjarmason
2022-12-16 23:28 ` Junio C Hamano
2022-12-17 14:46 ` Karthik Nayak
2022-12-16 23:26 ` Junio C Hamano
2022-12-17 14:49 ` Karthik Nayak
2022-12-17 10:53 ` Phillip Wood
2022-12-17 14:52 ` Karthik Nayak
2022-12-19 9:45 ` Ævar Arnfjörð Bjarmason
2022-12-19 13:16 ` Karthik Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqcz8ikgxs.fsf@gitster.g \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=karthik.188@gmail$(echo .)com \
--cc=toon@iotcl$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox