Subject: Re: [PATCH v2] Propagate --quiet on submodule update to merge/rebase

From: Junio C Hamano <[email-masked]>
Date: Thu, 01 Oct 2020 08:49:59 -0700

Jonathan Nieder <[email-masked]> writes:

> Junio C Hamano wrote:
>> Theodore Dubois <[email-masked]> writes:
>
>>> Without this, commands such as
>>> git pull --rebase --recurse-submodules --quiet
>>> might produce non-quiet output from the merge or rebase.
>>>
>>> Also fix the parsing of git submodule update -v. Setting GIT_QUIET to 0
>>> has the same effect as setting GIT_QUIET to 1, because
>>> ${GIT_QUIET:+--quiet} only checks whether GIT_QUIET is set or unset.
>>
>> Thanks.
>>
>> Will queue with the following log message.
>>
>>     submodule update: silence underlying merge/rebase "--quiet" is given
>
> Missing 'when' before '"--quiet"', as Eric noticed.
>
> Aside from that,
> Reviewed-by: Jonathan Nieder <[email-masked]>
>
> Thanks, all.

I just noticed that our names were on the original change that
introduced the broken GIT_QUIET=0; hopefully this time around we did
a better job at reviewing the change? ;-)

Thanks.