From: Junio C Hamano <gitster@pobox•com>
To: Marc-Antoine Ruel <maruel@chromium•org>
Cc: Eric Sunshine <sunshine@sunshineco•com>, git@vger•kernel.org
Subject: Re: [PATCH] grep: Add option --max-line-len
Date: Mon, 27 Nov 2017 11:08:02 +0900 [thread overview]
Message-ID: <xmqqd144fp8d.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <CAN+rsqnnFXxh4=mk8L5Hzk=f=rTU101XiO-GvepSXsaVePOkZQ@mail.gmail.com> (Marc-Antoine Ruel's message of "Sun, 26 Nov 2017 20:58:42 -0500")
Marc-Antoine Ruel <maruel@chromium•org> writes:
> [second try, now with text format]
>
> Thanks a lot for the reviews. Replying to both.
>
> If I send a follow up, I'll fix the commit description and the help
> string, remove the shorthand -M, write a more sensible test.
>
> ...
>
> Thanks for the thoughtful analysis. My main motivation was (1), thus
> filtering with a pathspec is much better than trying to work around
> the issue. The issues raised in the review are significant enough that
> committing this patch could cause significant issues; I don't know how
> to resolve handling with -v and how to handle tabs.
OK. Thanks for thinking it through.
prev parent reply other threads:[~2017-11-27 2:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-23 15:41 [PATCH] grep: Add option --max-line-len Marc-Antoine Ruel
2017-11-23 19:24 ` Eric Sunshine
2017-11-24 1:44 ` Junio C Hamano
[not found] ` <CAN+rsqmEWHhnQvktxsLJC2CkOQEmBL3b_xjRkEOHzV8W72zJew@mail.gmail.com>
2017-11-27 1:58 ` Marc-Antoine Ruel
2017-11-27 2:08 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqd144fp8d.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=maruel@chromium$(echo .)org \
--cc=sunshine@sunshineco$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox