From: Junio C Hamano <gitster@pobox•com>
To: Stefan Beller <sbeller@google•com>
Cc: git@vger•kernel.org, bmwill@google•com, jacob.keller@gmail•com
Subject: Re: [PATCHv2 1/3] submodule config: inline config_from_{name, path}
Date: Mon, 21 Nov 2016 19:27:10 -0800 [thread overview]
Message-ID: <xmqqd1hogpo1.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20161121232709.8906-2-sbeller@google.com> (Stefan Beller's message of "Mon, 21 Nov 2016 15:27:07 -0800")
Stefan Beller <sbeller@google•com> writes:
> There is no other user of config_from_{name, path}, such that there is no
> reason for the existence of these one liner functions. Just inline these
> to increase readability.
>
> Signed-off-by: Stefan Beller <sbeller@google•com>
> Signed-off-by: Junio C Hamano <gitster@pobox•com>
> ---
Makes sense.
next prev parent reply other threads:[~2016-11-22 3:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-21 23:27 [PATCHv2 0/3] submodule-config: clarify/cleanup docs and header Stefan Beller
2016-11-21 23:27 ` [PATCHv2 1/3] submodule config: inline config_from_{name, path} Stefan Beller
2016-11-22 3:27 ` Junio C Hamano [this message]
2016-11-21 23:27 ` [PATCHv2 2/3] submodule-config: rename commit_sha1 to commit_or_tree Stefan Beller
2016-11-22 0:11 ` Brandon Williams
2016-11-22 0:15 ` Stefan Beller
2016-11-22 0:16 ` Brandon Williams
2016-11-22 1:25 ` Stefan Beller
2016-11-22 3:37 ` Junio C Hamano
2016-11-22 20:03 ` Stefan Beller
2016-11-21 23:27 ` [PATCHv2 3/3] submodule-config: clarify parsing of null_sha1 element Stefan Beller
2016-11-22 0:09 ` Brandon Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqd1hogpo1.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=bmwill@google$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=jacob.keller@gmail$(echo .)com \
--cc=sbeller@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox