From: Junio C Hamano <gitster@pobox•com>
To: "Torsten Bögershausen" <tboegi@web•de>
Cc: git@vger•kernel.org
Subject: Re: [PATCH v10] ls-files: add eol diagnostics
Date: Tue, 12 Jan 2016 09:50:37 -0800 [thread overview]
Message-ID: <xmqqd1t6vg9e.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <56949C53.5030605@web.de> ("Torsten Bögershausen"'s message of "Tue, 12 Jan 2016 07:25:23 +0100")
Torsten Bögershausen <tboegi@web•de> writes:
> On 01/11/2016 06:48 PM, Junio C Hamano wrote:
>
> Thanks for comments
>>> + if (line_terminator == '\n')
>>> + printf("i/%-6s w/%-6s attr/%-9s ", i_txt, w_txt, a_txt);
>> Can we do something better than these hard-coded constants? Why
>> can't the "one HT between each" approach be used for both?
> v11 will make more clear, that currently "eol=crlf" is the same as
> "text eol=crlf".
> The shortest attr is then "", the longest "text eol=crlf".
> Using '\t' as a separator makes the output cluttered for a human reader.
>
> When parsing the output, the '\t' is much more convenient (and that's
> what t0027 wil use).
> Is there any chance to have a selection between human-friendly and
> script-friendly ?
> Would an option -e (eol info using spaces) vs --eol (eol info with
> TABs) make sence ?
I do not think so; what you have in v10 is infinitely better.
What I found disturbing the most was these hardcoded numbers 6,6,9
in the printf format.
prev parent reply other threads:[~2016-01-12 17:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-10 17:16 [PATCH v10] ls-files: add eol diagnostics tboegi
2016-01-11 17:48 ` Junio C Hamano
2016-01-12 6:25 ` Torsten Bögershausen
2016-01-12 17:50 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqd1t6vg9e.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=tboegi@web$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox