From: Junio C Hamano <gitster@pobox•com>
To: Johannes Sixt <j6t@kdbg•org>
Cc: Johannes Schindelin <johannes.schindelin@gmx•de>,
Ben Walton <bdwalton@gmail•com>,
git@vger•kernel.org
Subject: Re: [PATCH 2/2] Fix sed usage in tests to work around broken xpg4/sed on Solaris
Date: Mon, 20 Jul 2015 09:07:04 -0700 [thread overview]
Message-ID: <xmqqd1zmzuc7.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <55AB6290.2090003@kdbg.org> (Johannes Sixt's message of "Sun, 19 Jul 2015 10:40:48 +0200")
Johannes Sixt <j6t@kdbg•org> writes:
>> I really wonder why the previous ">file+ && mv -f file+ file" dance
>> needs to be replaced?
>
> The sed must be replaced because some versions on Solaris choke on the
> incomplete last line in the file.
Switching from sed to perl is not being questioned.
I think Dscho is asking about the use of "-i", when the original
idiom ">target+ && mv -f target+ target" worked perfectly fine.
I.e.
perl -p -e '...' file >file+ &&
mv file+ file
next prev parent reply other threads:[~2015-07-20 16:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-18 15:21 [PATCH 2/2] Fix sed usage in tests to work around broken xpg4/sed on Solaris Ben Walton
2015-07-19 3:39 ` Eric Sunshine
2015-07-19 6:54 ` Johannes Sixt
2015-07-19 7:37 ` Johannes Schindelin
2015-07-19 8:40 ` Johannes Sixt
2015-07-20 16:07 ` Junio C Hamano [this message]
2015-07-22 9:52 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqd1zmzuc7.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=bdwalton@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=j6t@kdbg$(echo .)org \
--cc=johannes.schindelin@gmx$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox