From: Junio C Hamano <gitster@pobox•com>
To: Lawrence Siebert <lawrencesiebert@gmail•com>
Cc: git@vger•kernel.org, Jeff King <peff@peff•net>
Subject: Re: [PATCH] rev-list: add --count to usage guide
Date: Wed, 01 Jul 2015 08:19:40 -0700 [thread overview]
Message-ID: <xmqqd20bc3cj.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1435742651-15053-1-git-send-email-lawrencesiebert@gmail.com> (Lawrence Siebert's message of "Wed, 1 Jul 2015 02:24:11 -0700")
Lawrence Siebert <lawrencesiebert@gmail•com> writes:
> --count should be mentioned in the usage guide, this updates code and
> documentation.
>
> Signed-off-by: Lawrence Siebert <lawrencesiebert@gmail•com>
> ---
Sounds good. While at it, perhaps add a mention (perhaps by
creating a BUGS section at the end of the file) that --count
with --use-bitmap-index ignores pathspec silently?
> Documentation/git-rev-list.txt | 1 +
> builtin/rev-list.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/Documentation/git-rev-list.txt b/Documentation/git-rev-list.txt
> index b10ea60..7b49c85 100644
> --- a/Documentation/git-rev-list.txt
> +++ b/Documentation/git-rev-list.txt
> @@ -56,6 +56,7 @@ SYNOPSIS
> [ --reverse ]
> [ --walk-reflogs ]
> [ --no-walk ] [ --do-walk ]
> + [ --count ]
> [ --use-bitmap-index ]
> <commit>... [ \-- <paths>... ]
>
> diff --git a/builtin/rev-list.c b/builtin/rev-list.c
> index ff84a82..ee9e872 100644
> --- a/builtin/rev-list.c
> +++ b/builtin/rev-list.c
> @@ -42,6 +42,7 @@ static const char rev_list_usage[] =
> " --abbrev=<n> | --no-abbrev\n"
> " --abbrev-commit\n"
> " --left-right\n"
> +" --count\n"
> " special purpose:\n"
> " --bisect\n"
> " --bisect-vars\n"
next prev parent reply other threads:[~2015-07-01 15:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-01 9:24 [PATCH] rev-list: add --count to usage guide Lawrence Siebert
2015-07-01 15:19 ` Junio C Hamano [this message]
2015-07-01 18:42 ` [PATCH] rev-list: disable --use-bitmap-index when pruning commits Jeff King
2015-07-01 19:00 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqd20bc3cj.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=lawrencesiebert@gmail$(echo .)com \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox