From: Junio C Hamano <gitster@pobox•com>
To: Tay Ray Chuan <rctay89@gmail•com>
Cc: "Git Mailing List" <git@vger•kernel.org>
Subject: Re: [PATCH v2 0/2] make commit --verbose work with --no-status
Date: Thu, 04 Jun 2015 11:39:45 -0700 [thread overview]
Message-ID: <xmqqd21buxla.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1433440591-30917-1-git-send-email-rctay89@gmail.com> (Tay Ray Chuan's message of "Fri, 5 Jun 2015 01:56:29 +0800")
Tay Ray Chuan <rctay89@gmail•com> writes:
> When running git-commit`, --verbose appends a diff to the prepared
> message, while --no-status omits git-status output.
The --verbose option is called --verbose and not --diff or --patch
for a reason, though. The default is to show extra information as
comments, and verbose tells us to make that extra information more
verbose. We call that extra information "status", so it is natural
for "--no-status" to drop that extra information.
> ; thus, one would
> expect --verbose --no-status to give a commit message with a diff of
> the commit without git-status output.
>
> However, this is not what happens
And for a good reason, I would think.
next prev parent reply other threads:[~2015-06-04 18:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-04 17:56 [PATCH v2 0/2] make commit --verbose work with --no-status Tay Ray Chuan
2015-06-04 17:56 ` [PATCH v2 1/2] extract setting of wt_status.commitable flag out of wt_status_print_updated() Tay Ray Chuan
2015-06-04 17:56 ` [PATCH v2 2/2] make commit --verbose work with --no-status Tay Ray Chuan
2015-06-04 21:34 ` [PATCH v2 1/2] extract setting of wt_status.commitable flag out of wt_status_print_updated() Junio C Hamano
2015-06-04 18:39 ` Junio C Hamano [this message]
2015-06-05 12:40 ` [PATCH v2 0/2] make commit --verbose work with --no-status Tay Ray Chuan
2015-06-05 16:03 ` Junio C Hamano
2015-06-05 16:48 ` Tay Ray Chuan
2015-06-05 17:13 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqd21buxla.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=rctay89@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox