public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Junio C Hamano <gitster@pobox•com>
To: "brian m. carlson" <sandals@crustytoothpaste•net>
Cc: git@vger•kernel.org, Duy Nguyen <pclouds@gmail•com>
Subject: Re: [PATCH v3 0/4] Improve push performance with lots of refs
Date: Tue, 23 Dec 2014 10:40:54 -0800	[thread overview]
Message-ID: <xmqqd27a2oqx.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1419336082-283091-1-git-send-email-sandals@crustytoothpaste.net> (brian m. carlson's message of "Tue, 23 Dec 2014 12:01:18 +0000")

"brian m. carlson" <sandals@crustytoothpaste•net> writes:

> The only change from v2 is the addition of a fourth patch, which fixes
> t5500.  It's necessary because the test wants packs for fetches to
> shallow clones to be minimal.
>
> I'm not especially thrilled with having to provide a --shallow command
> line argument, but the alternative is to buffer a potentially large
> amount of data in order to determine whether the remote side is shallow.

You spell "--thin-aggressive" as two words, "--thin" "--shallow", in
this series, essentially, no?

I think this is going in the right direction.  The "shallow"
propagated on the wire from the fetcher is the right thing to use
to make this decision.

I wonder if the call to is_repository_shallow() is still necessary
(read: I would prefer to see it go away) where we decide between
"--objects-edge" and "--objects-edge-aggressive".

Here is the relevant part from 4/4:

@@ -2711,7 +2714,7 @@ int cmd_pack_objects(int argc, const char **argv, const char *prefix)
 	argv_array_push(&rp, "pack-objects");
 	if (thin) {
 		use_internal_rev_list = 1;
-		argv_array_push(&rp, is_repository_shallow()
+		argv_array_push(&rp, is_repository_shallow() || shallow
 				? "--objects-edge-aggressive"
 				: "--objects-edge");
 	} else

next prev parent reply	other threads:[~2014-12-23 18:41 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-23 12:01 [PATCH v3 0/4] Improve push performance with lots of refs brian m. carlson
2014-12-23 12:01 ` [PATCH v3 1/4] Documentation: add missing article in rev-list-options.txt brian m. carlson
2014-12-23 12:01 ` [PATCH v3 2/4] rev-list: add an option to mark fewer edges as uninteresting brian m. carlson
2014-12-23 17:55   ` Michael Blume
2014-12-23 18:51     ` Jeff King
2014-12-23 19:11       ` Junio C Hamano
2014-12-24 21:26       ` brian m. carlson
2014-12-23 12:01 ` [PATCH v3 3/4] pack-objects: use --objects-edge-aggressive only for shallow repos brian m. carlson
2014-12-23 12:01 ` [PATCH v3 4/4] upload-pack: use --objects-edge-aggressive for shallow fetches brian m. carlson
2014-12-23 18:40 ` Junio C Hamano [this message]
2014-12-24 21:31   ` [PATCH v3 0/4] Improve push performance with lots of refs brian m. carlson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqd27a2oqx.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=pclouds@gmail$(echo .)com \
    --cc=sandals@crustytoothpaste$(echo .)net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox