From: Junio C Hamano <gitster@pobox•com>
To: Eric Wong <normalperson@yhbt•net>
Cc: git@vger•kernel.org
Subject: Re: [PATCH] Git.pm: add specified name to tempfile template
Date: Wed, 29 Oct 2014 12:50:49 -0700 [thread overview]
Message-ID: <xmqqd29ay7s6.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20141029193155.GA2232@dcvr.yhbt.net> (Eric Wong's message of "Wed, 29 Oct 2014 19:31:55 +0000")
Eric Wong <normalperson@yhbt•net> writes:
> This should help me track down errors in git-svn more easily:
>
> write .git/Git_XXXXXX: Bad file descriptor
> at /usr/lib/perl5/SVN/Ra.pm line 623
>
> Signed-off-by: Eric Wong <normalperson@yhbt•net>
> ---
> Not sure you want to take this separately or in a git-svn pull.
> Still working on the error this patch is meant to help me find.
Thanks; I think it is OK for it to be part of the git-svn update.
No other active perl/Git.pm user that wants to have access to this
facility early exists as far as I can see ;-)
>
> perl/Git.pm | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/perl/Git.pm b/perl/Git.pm
> index 204fdc6..b5905ee 100644
> --- a/perl/Git.pm
> +++ b/perl/Git.pm
> @@ -1294,8 +1294,11 @@ sub _temp_cache {
> $tmpdir = $self->repo_path();
> }
>
> + my $n = $name;
> + $n =~ s/\W/_/g; # no strange chars
> +
> ($$temp_fd, $fname) = File::Temp::tempfile(
> - 'Git_XXXXXX', UNLINK => 1, DIR => $tmpdir,
> + "Git_${n}_XXXXXX", UNLINK => 1, DIR => $tmpdir,
> ) or throw Error::Simple("couldn't open new temp file");
>
> $$temp_fd->autoflush;
prev parent reply other threads:[~2014-10-29 19:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-29 19:31 [PATCH] Git.pm: add specified name to tempfile template Eric Wong
2014-10-29 19:50 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqd29ay7s6.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=normalperson@yhbt$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox