From: Junio C Hamano <gitster@pobox•com>
To: "Michael S. Tsirkin" <mst@redhat•com>
Cc: git@vger•kernel.org
Subject: Re: [PATCH v4 2/6] test: add test_write_lines helper
Date: Wed, 23 Apr 2014 10:34:30 -0700 [thread overview]
Message-ID: <xmqqd2g80x21.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1398255277-26303-2-git-send-email-mst@redhat.com> (Michael S. Tsirkin's message of "Wed, 23 Apr 2014 15:14:55 +0300")
"Michael S. Tsirkin" <mst@redhat•com> writes:
> As suggested by Junio.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat•com>
> ---
Ehh, I would probably not suggest such an implementation though.
test_write_lines () {
printf "%s\n" "$@"
}
might be, but not with "echo" and semicolon on the same line as
"for" ;-).
> t/test-lib-functions.sh | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/t/test-lib-functions.sh b/t/test-lib-functions.sh
> index aeae3ca..2fa6453 100644
> --- a/t/test-lib-functions.sh
> +++ b/t/test-lib-functions.sh
> @@ -712,6 +712,13 @@ test_ln_s_add () {
> fi
> }
>
> +# This function writes out its parameters, one per line
> +test_write_lines () {
> + for line in "$@"; do
> + echo "$line"
> + done
> +}
> +
> perl () {
> command "$PERL_PATH" "$@"
> }
next prev parent reply other threads:[~2014-04-23 17:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-23 12:14 [PATCH v4 1/6] diff: add a config option to control orderfile Michael S. Tsirkin
2014-04-23 12:14 ` [PATCH v4 2/6] test: add test_write_lines helper Michael S. Tsirkin
2014-04-23 17:34 ` Junio C Hamano [this message]
2014-04-23 17:58 ` Michael S. Tsirkin
2014-04-23 12:14 ` [PATCH v4 3/6] tests: new test for orderfile options Michael S. Tsirkin
2014-04-23 17:38 ` Junio C Hamano
2014-04-23 18:00 ` Michael S. Tsirkin
2014-04-23 12:15 ` [PATCH v4 4/6] patch-id: make it stable against hunk reordering Michael S. Tsirkin
2014-04-23 17:39 ` Junio C Hamano
2014-04-23 17:57 ` Michael S. Tsirkin
2014-04-23 22:05 ` Junio C Hamano
2014-04-24 6:29 ` Michael S. Tsirkin
2014-04-24 18:13 ` Junio C Hamano
2014-04-23 12:15 ` [PATCH v4 5/6] patch-id: document new behaviour Michael S. Tsirkin
2014-04-23 12:15 ` [PATCH v4 6/6] patch-id-test: test stable and unstable behaviour Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqd2g80x21.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=mst@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox