From: Junio C Hamano <gitster@pobox•com>
To: tanay abhra <tanayabh@gmail•com>
Cc: git@vger•kernel.org
Subject: Re: [PATCH v4] commit.c: use skip_prefix() instead of starts_with()
Date: Wed, 05 Mar 2014 14:23:13 -0800 [thread overview]
Message-ID: <xmqqd2i02sku.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CAEc54XB3hdsJcO4QFuqFHi+mZtZDrV2wFdMQ1uHiPrxzfo99jw@mail.gmail.com> (tanay abhra's message of "Wed, 5 Mar 2014 03:59:55 +0530")
tanay abhra <tanayabh@gmail•com> writes:
> On Wed, Mar 5, 2014 at 3:41 AM, Junio C Hamano <gitster@pobox•com> wrote:
>
>> Junio C Hamano <gitster@pobox•com> writes:
>>
>> >> + found = skip_prefix(buf, sigcheck_gpg_status[i].check + 1);
>> >> + if(!found) {
>>
>> Missing SP between the control keyword and parenthesized expression
>> the keyword uses.
>>
>> I've fixed this (and the broken indentation) locally and queued the
>> result to 'pu', so no need to resend to correct this one.
>>
>> Thanks.
>>
>>
> Sorry about the indentation, it was due to not setting the tab to eight
> spaces. I found your mail late, so I had already
> sent a revised patch [1]. Please ignore that mail.
>
> Also , what should be my next step ,should I present a rough draft of a
> proposal , or tackle other bugs on the mailing list?
As far as I, as the maintainer of the project, am concerned [*1*],
we are done and I expect/require nothing more from you on this
change.
The MicroProject page says:
... If you've already done a microproject and are itching to do
more, then get involved in other ways, like finding and fixing
other problems in the code, or improving the documentation or
code comments, or helping to review other people's patches on
the mailing list, or answering questions on the mailing list or
in IRC, or writing new tests, etc., etc. In short, start doing
things that other Git developers do!
FYI, [GSoC 2014 timeline] (Google for it) tells us that would-be
students are supposed to be discussing project ideas with their
mentoring organizations now, in preparation for the actual student
application that begins on Mar 10 and ends on Mar 21.
[Footnote]
*1* I should mention that I am not involved in GSoC administration
and student selection for the Git project.
prev parent reply other threads:[~2014-03-05 22:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-04 21:06 [PATCH v4] commit.c: use skip_prefix() instead of starts_with() Tanay Abhra
2014-03-04 21:23 ` Junio C Hamano
2014-03-04 22:11 ` Junio C Hamano
2014-03-04 22:32 ` Tanay Abhra
[not found] ` <CAEc54XB3hdsJcO4QFuqFHi+mZtZDrV2wFdMQ1uHiPrxzfo99jw@mail.gmail.com>
2014-03-05 22:23 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqd2i02sku.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=tanayabh@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox